goodfella / googletest

Automatically exported from code.google.com/p/googletest
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

fuse script puts EXPECT_FATAL_FAILURE into .cc file #356

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
EXPECT_FATAL_FAILURE is a define in gtest-spi.h but is put into gtest-all.cc 
file after fusing.

This requires to include .cc file into file where EXPECT_FATAL_FAILURE is used, 
which is very strange. Also it makes impossible to use EXPECT_FATAL_FAILURE in 
two or more files, which can be a real problem :)

* What steps will reproduce the problem?
1. Just use EXPECT_FATAL_FAILURE with fused files

* What version of Google Test are you using? On what operating system?
1.5.0, Windows (but this doesn't figure)

Original issue reported on code.google.com by vasily.v...@gmail.com on 28 Feb 2011 at 4:39

GoogleCodeExporter commented 9 years ago
When gtest-spi.h was created, the idea was that it's not meant for "ordinary" 
users -- instead, it's for people who write testing frameworks/utilities on top 
of gtest.  Therefore, it's not #included by gtest.h.

It might make sense to make gtest.h include gtest-spi.h (and eliminate the 
distinction of the two kinds of users), which will fix this problem.

Original comment by w...@google.com on 28 Feb 2011 at 5:56