search

goodformandspectacle / v_and_a

1 stars 0 forks source link

Possible URL encoding issue? #15

Closed george08 closed 9 years ago

george08 commented 9 years ago

Feels like it's breaking if there's a "." in the URL, but not sure.

http://va.goodformandspectacle.com/facets/artist/World's%20Wear%20Ltd. http://va.goodformandspectacle.com/facets/artist/Tootal,%20Broadhurst,%20Lee%20&%20Co. http://va.goodformandspectacle.com/facets/artist/James%20Rothwell%20Ltd.

All get to here:

image

infovore commented 9 years ago

Hnnnnng yes. Annoying. I'll have a think as to best way's around that.

On 18 Dec 2014, at 11:10, George Oates notifications@github.com wrote:

Feels like it's breaking if there's a "." in the URL, but not sure.

http://va.goodformandspectacle.com/facets/artist/World's%20Wear%20Ltd. http://va.goodformandspectacle.com/facets/artist/Tootal,%20Broadhurst,%20Lee%20&%20Co. http://va.goodformandspectacle.com/facets/artist/James%20Rothwell%20Ltd.

All get to here:

— Reply to this email directly or view it on GitHub.

infovore commented 9 years ago

This is being deployed as I type.

george08 commented 9 years ago

Now seeing another error on all three examples:

image

george08 commented 9 years ago

(Is that a 404?)

infovore commented 9 years ago

The auto-linked text in github has not linked up the final period, assuming that's not part of the URL. When you click the links above, they'll 404 because, technically, there's no artist with that name (sans period). - if you highlight the whole URL including the trailing ., and copy/paste it into the URL bar, it works correctly - and the links inside the pages also function correctly.

(That is the default 404 page. I can replace it straightforwardly enough if you'd like.)

george08 commented 9 years ago

Thanks.

What a shame this object doesn't have an image: http://va.goodformandspectacle.com/things/404

:)

infovore commented 9 years ago

gosh