search

goodformandspectacle / v_and_a

1 stars 0 forks source link

Update Date Graph #18

Open infovore opened 9 years ago

infovore commented 9 years ago

date-graph

Proposed updates to the date graph from George

That looks good to me. I'm going to add the copy right now because it'll take all of a few minutes; the markup changes to the header will take a bit longer.

My only query would be the lack of a submit button: the form won't change automatically; are we OK that people will guess to push enter?

Oh, also: the copy in between the numbers might need altering in one particular case. If you've chosen a range where there is < [CAP] objects, it's correct to say "8346 objects created in this date range". However, if you pick a range and the hard cap kicks in… it feels like it should say something like "at least 5,000 objects created in this date range".

That copy doesn't feel right to me - after all, we're only showing 5000, but if it's 5,000 of (say) the 100k between 1600 and 1800… I feel we should communicate the hard cap.

Assigned to you for feedback, but I'm going to implement the prose right now.

infovore commented 9 years ago

I've added the paragraph of copy to the page: http://va.goodformandspectacle.com/completeness

the markup/layout changes to the form and headers are still to come.

george08 commented 9 years ago

I think no submit is OK. (No button on google.com anymore, for example.)

george08 commented 9 years ago

Can that h1 be white, please?

image

george08 commented 9 years ago

Just noticed masses of blank space underneath the graph... scroll down to the bottom of a page like http://va.goodformandspectacle.com/completeness?start=1600&end=1700...

infovore commented 9 years ago

All sounds OK:

Just making a list so I know precisely what I'm doing.

infovore commented 9 years ago

So I'm making some progress on this. The h1 is white, the form submits on enter, and the page is never too long.

I've taken a best pass at the described design - centering elements between two block elements is always a pain, and I'm not 100% happy with the way I've done it, but I believe it works in everything.

My only catch is small screens. Everything is fine at iPad portrait resolution, but when we come down to iPhone portrait, it's a mess:

image

(It's fine on iPhone 5 landscape, and just about bearable on iPhone 4 landscape).

Obviously this mess is my doing. The graph is OK, because it's done at pixel-scale, but the text is a bit skew-whiff. Reasons for that are, primarily, font-size related. Options are:

Thoughts? Otherwise, I think we're nearly there.

This is currently live at http://va.goodformandspectacle.com/completeness

infovore commented 9 years ago

NB: looks like this new layout is playing havoc with the sticky header, so I'm now working on fixing that.

infovore commented 9 years ago

OK, I've used a slightly different stickying plugin that has solved my issue. The only catch I've found is making the sticky header work if you resize the window is rather complex, but really, that feels like an edge case for this prototype - so I think that's all good now.

george08 commented 9 years ago

For > 5k objects issue, how about:

"Showing 5,000 of 135,236 objects in this date range"

BTW, totally fine with the edge case above.

infovore commented 9 years ago

OK, I'll look into that heading tomorrow - hopefully the count query won't add too much to page overhead.

george08 commented 9 years ago

If getting the count is heavy but knowing there is one is cheap we can say something else.

Actually I think we can make the note simpler too.

Could be: 4,346 objects Showing 5,000 objects (the maximum)

Or something like that.

On 4 Jan 2015, at 14:44, Tom Armitage notifications@github.com wrote:

OK, I'll look into that heading tomorrow - hopefully the count query won't add too much to page overhead.

— Reply to this email directly or view it on GitHub.

infovore commented 9 years ago

OK, I like that as an alternative, but I'll see what I can do.

On Sun, Jan 4, 2015 at 8:13 PM, George Oates notifications@github.com wrote:

If getting the count is heavy but knowing there is one is cheap we can say something else.

Actually I think we can make the note simpler too.

Could be: 4,346 objects Showing 5,000 objects (the maximum)

Or something like that.

On 4 Jan 2015, at 14:44, Tom Armitage notifications@github.com wrote:

OK, I'll look into that heading tomorrow - hopefully the count query won't add too much to page overhead.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/goodformandspectacle/v_and_a/issues/18#issuecomment-68647011 .

Tom Armitage http://infovore.org 07813 060578

george08 commented 9 years ago

Page already takes ages. I wouldn't worry about it. Might be better to add a flag that tells us if the site shits itself on Tuesday ;)

On 4 Jan 2015, at 21:21, Tom Armitage notifications@github.com wrote:

OK, I like that as an alternative, but I'll see what I can do.

On Sun, Jan 4, 2015 at 8:13 PM, George Oates notifications@github.com wrote:

If getting the count is heavy but knowing there is one is cheap we can say something else.

Actually I think we can make the note simpler too.

Could be: 4,346 objects Showing 5,000 objects (the maximum)

Or something like that.

On 4 Jan 2015, at 14:44, Tom Armitage notifications@github.com wrote:

OK, I'll look into that heading tomorrow - hopefully the count query won't add too much to page overhead.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/goodformandspectacle/v_and_a/issues/18#issuecomment-68647011 .

Tom Armitage http://infovore.org 07813 060578 — Reply to this email directly or view it on GitHub.

infovore commented 9 years ago

OK, let's go for the simple option, and see #20 for my best bet at letting us know when site goes down.

infovore commented 9 years ago

The altered text is now live.