search

goodhosts / hostsfile

Go package for interfacing with an OS hosts file
Apache License 2.0
30 stars 12 forks source link

Feature Request: Method to Create Hostsfile from String #55

Open spencercjh opened 5 months ago

spencercjh commented 5 months ago

I would like to express my gratitude for your contributions to the project. The two New methods for reading from a file are extremely convenient and useful in my work.

However, I've encountered a scenario where I need to read the contents of a hostsfile stored in memory. My workaround is to write the in-memory hostsfile to a temporary file and then use the existing API to read it. This process is not ideal and could be streamlined.

Therefore, I would like to propose a new feature: a NewHostsFromStr method that allows the creation of a hostsfile directly from a string. Maybe we can just expose the existing test method loadString?

If this proposal aligns with the project's goals, I want to contribute to its implementation. I look forward to hearing your thoughts on this suggestion.

Thank you for considering my proposal.

luthermonson commented 5 months ago

only concern i have with exposing it is probably all the funcs which need a file path to work e.g. IsWritable and Flush. Would you expect to set the Path yourself for those to work or would NewHostsFromStr take two params, the string and the path where you eventually want it?

spencercjh commented 4 months ago

only concern i have with exposing it is probably all the funcs which need a file path to work e.g. IsWritable and Flush. Would you expect to set the Path yourself for those to work or would NewHostsFromStr take two params, the string and the path where you eventually want it?

I got your points. This may require reimplementing all the existing interfaces all over again.