goodjoblife / GoodJobShare

GoodJob 職場透明化運動
https://www.goodjob.life/
MIT License
82 stars 11 forks source link

feat: add averageSectionRating queryQL query #1436

Closed YongChenSu closed 1 week ago

YongChenSu commented 1 week ago

Close #1431

這個 PR 是?

  1. add averageSectionRating queryQL query to make jobtitle card showing OverallRating。職稱總覽頁面、職稱評價頁面同時顯示新舊版卡片。

Screenshots

image

image

我應該如何手動測試?

起 local 可看到職稱總覽頁面、職稱評價頁面同時顯示新舊版卡片。

YongChenSu commented 1 week ago

個人記錄一下頁面或 component 觸發順序:

  1. src/selectors/companyAndJobTitle.js image

  2. src/components/CompanyAndJobTitle/WorkExperiences/index.js image

  3. src/selectors/companyAndJobTitle.js image

  4. src/actions/jobTitle.js image

mark86092 commented 1 week ago

這個是m2要上線的嗎

YongChenSu commented 1 week ago

這個是m2要上線的嗎

應該不是,我看 issue 單是寫 M1 #1431

mark86092 commented 1 week ago

那要送到master branch, as dev branch 給m2用

YongChenSu commented 1 week ago

那要送到master branch, as dev branch 給m2用

是併入 master 的意思嗎? 像是現在這樣 image