search

goodmami / mrs-to-penman

Utilities for converting MRS data to the PENMAN serialization of DMRS
MIT License
2 stars 1 forks source link

Issue handling Timeout #1

Closed ryan-ph closed 6 years ago

ryan-ph commented 6 years ago

https://github.com/goodmami/mrs-to-penman/blob/765e28bbf2b08e46904da82a9e552513cb0d4c82/mrs_to_penman.py#L49

Should be changed to append '--timeout' and str(args.timeout) separately rather than appending a list of the two to cmdargs.

goodmami commented 6 years ago

Thanks! I think cmdargs.extend(...) would work just as well. I've committed that change, but I'm not set up to test on this machine. Can you confirm if it works?

ryan-ph commented 6 years ago

Yea, that also seems to work! Thanks.

goodmami commented 6 years ago

@ryanp97 Thanks for confirming!