search

goodmami / penman

PENMAN notation (e.g. AMR) in Python
https://penman.readthedocs.io/
MIT License
135 stars 26 forks source link

Encoding generalizations #110

Closed BramVanroy closed 1 year ago

BramVanroy commented 1 year ago

Currently, some issues may be experienced by Windows users because of encoding issues. The reason is that Windows unfortunately still relies on cp1252 rather than utf-8. This PR explicitly sets utf-8 where applicable (set-up files) and allows user-defined encoding elsewhere (in the codec module as well as the command line script).

Tests completed successfully.

Closes #109

goodmami commented 1 year ago

@BramVanroy changes are now published to PyPI in version 1.2.2. Cheers

BramVanroy commented 1 year ago

Thanks a lot for the quick responses and fast iteration! Also really appreciate the quick push to PyPi so I can readily start using it. Awesome!