search

goodmami / penman

PENMAN notation (e.g. AMR) in Python
https://penman.readthedocs.io/
MIT License
141 stars 26 forks source link

Attribute-first order #62

Closed goodmami closed 4 years ago

goodmami commented 4 years ago

The current version of the AMR editor seems to always put attributes immediately after the concept, so maybe the canonical order should be updated to do so. Or it could be another reordering option. Also see #59.

goodmami commented 4 years ago

Doing this would require sending more information than just the role to the sorting functions, which I'm not prepared to do. Instead, making an optional parameter on rearrange() would work, since that function can determine if things are attributes or not.

I don't think this parameter needs to go on reconfigure() as well because it makes less sense to sort attributes first when reconfiguring.

goodmami commented 4 years ago

Also, I'm renaming this as it cannot go on Model.canonical_order() since it's not an ordering function but a parameter to rearrange().