search

goodmami / wn

A modern, interlingual wordnet interface for Python
https://wn.readthedocs.io/
MIT License
197 stars 19 forks source link

Add wn-editor as extra package #163

Closed Hypercookie closed 2 years ago

Hypercookie commented 2 years ago

This merge request adds wn-editor as an extra package as discussed in #17. You can find more information about wn-editor here.

If any changes to wn-editor are required to merge this, please let me know and I will fix them as soon as possible.

Thanks for the good work!

Hypercookie commented 2 years ago

@goodmami I dont want to pressure you! Just asking if this will be possible at all. Thanks!

goodmami commented 2 years ago

Sorry, you were right to remind me. I've been sitting on this too long. I've now tested this and there were no issues installing the package. I'll merge the PR.

As a note (perhaps to myself for later), I'm having some second thoughts about using the extras mechanism for installing this. I offered in #17 to use the extra as a way of increasing visibility, but a call-out in the Wn's README would work just as well, or better. Extras, I think, normally install things that enable some optional functionality in the main package instead of another tool (that is, optional dependencies instead of dependents). We can revisit this decision later, e.g., for a 1.0 release.

goodmami commented 2 years ago

The failing lint test was not due to this PR. I'll fix it separately.

Hypercookie commented 2 years ago

Thanks for merging! I will keep wn-editor up to date. If anything comes up just ping me somewhere and we will discuss!