search

goodmind / sunflower-fm

Automatically exported from code.google.com/p/sunflower-fm
GNU General Public License v3.0
1 stars 0 forks source link

Moving to trash on NTFS not possible #269

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Go to a NTFS mounted drive and press del on a file. It should be moved to the 
trash. This is not possible (Ubuntu 12.04.1) because of how NTFS in handled. 
The 'Move to trash'-dialog hangs/idles. Cancel-button does nothing.

Expected output: Ask if it's OK to permanently remove the file instead of 
moving it to trash. Default to no.

0.1a53 on Ubuntu 12.04.1

Original issue reported on code.google.com by turboos...@gmail.com on 5 Feb 2013 at 1:54

GoogleCodeExporter commented 9 years ago 
Start Sunflower from terminal, and do the same operation. Then give me the 
output. I think I've fixed this issue long time ago.

Thanks for reporting!

Original comment by MeanEYE.rcf on 5 Feb 2013 at 1:55

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
In german, sorry:
"
~$  sunflower 
/usr/share/sunflower/application/accelerator_group.py:81: GtkWarning: 
IA__gtk_accel_group_connect: assertion `accel_key > 0' failed
  self._accel_group.connect_group(keyval, modifier, 0, self._handle_activate)
Exception in thread Thread-4:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 551, in __bootstrap_inner
    self.run()
  File "/usr/share/sunflower/application/operation.py", line 1210, in run
    remove_method(item)
  File "/usr/share/sunflower/application/operation.py", line 1163, in _trash_path
    self._source.trash_path(path, relative_to=self._source_path)
  File "/usr/share/sunflower/application/plugins/file_list/local_provider.py", line 56, in trash_path
    if not tmp.trash():
Error: Müll-Ordner konnte nicht gefunden oder angelegt werden
"
This is with the dialogue still open. Last line reads: 'Trash folder couldn't 
be found or created'
Clicking close or hitting cancel doesn't give additional output.

Original comment by turboos...@gmail.com on 5 Feb 2013 at 2:05

GoogleCodeExporter commented 9 years ago 
Ah, makes sense. But I should catch that exception. Okay, thanks. I'll fix it. 
For the time being you can use Shift + Delete to directly remove that file or 
directory without moving it to trash.

Original comment by MeanEYE.rcf on 5 Feb 2013 at 2:07

GoogleCodeExporter commented 9 years ago 
Oh my god how I love the internet. Thanks! I did just that.

Original comment by turboos...@gmail.com on 5 Feb 2013 at 2:09

GoogleCodeExporter commented 9 years ago 
Yes internetz is kewl. :P
Also, I forgot to mention, you can completely turn off trashing in preferences, 
not all people like that so I made an option. :D

Original comment by MeanEYE.rcf on 5 Feb 2013 at 2:10

GoogleCodeExporter commented 9 years ago 
Should be fixed. If you have repo version pull later and test if you don't 
mind. Otherwise wait for official release. :)

Original comment by MeanEYE.rcf on 16 Feb 2013 at 5:36

GoogleCodeExporter commented 9 years ago 
Can I try the repo version without overwriting my settings from deb install?

Original comment by turboos...@gmail.com on 16 Feb 2013 at 5:45

GoogleCodeExporter commented 9 years ago 
Well, you can backup your settings if you are afraid to experiment. They are 
located in ~/.config/sunflower.

Original comment by MeanEYE.rcf on 16 Feb 2013 at 5:47

GoogleCodeExporter commented 9 years ago 
I'm afraid the problem is still existing. I pulled from hg just now. my mount 
options are normal Ubuntu mount for NTFS iirc:
"/dev/sda3 on /media/BeautifulData type fuseblk 
(rw,noexec,nosuid,nodev,allow_other,default_permissions,blksize=4096)"
The dir itself is a symlink though:
"lrwxrwxrwx 1 turbo turbo 31 Jul 25  2012 Downloads -> 
/media/BeautifulData/Downloads//"
When I try do delete a file in Downloads/ sunflower says
"/home/turbo/Öffentlich/sunflower-fm/application/accelerator_group.py:81: 
GtkWarning: IA__gtk_accel_group_connect: assertion `accel_key > 0' failed
  self._accel_group.connect_group(keyval, modifier, 0, self._handle_activate)
Exception in thread Thread-10:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 551, in __bootstrap_inner
    self.run()
  File "/home/turbo/Öffentlich/sunflower-fm/application/operation.py", line 1210, in run
    remove_method(item)
  File "/home/turbo/Öffentlich/sunflower-fm/application/operation.py", line 1163, in _trash_path
    self._source.trash_path(path, relative_to=self._source_path)
  File "/home/turbo/Öffentlich/sunflower-fm/application/plugins/file_list/local_provider.py", line 56, in trash_path
    if not tmp.trash():
Error: Müll-Ordner konnte nicht gefunden oder angelegt werden"

Last line translates to "Error: Trash-dir couldn't be found or created"

Original comment by turboos...@gmail.com on 17 Feb 2013 at 12:48

GoogleCodeExporter commented 9 years ago 
Hm, you have to start version you pulled. My guess is that you are starting 
previous version. Just type ./Sunflower.py from directory where you cloned main 
repository.

Original comment by MeanEYE.rcf on 17 Feb 2013 at 12:52

GoogleCodeExporter commented 9 years ago 
The line just above the excerpt reads:
"turbo@turputer:~/Öffentlich/sunflower-fm$  ./Sunflower.py "
:P

Original comment by turboos...@gmail.com on 17 Feb 2013 at 12:53

GoogleCodeExporter commented 9 years ago 
http://code.google.com/p/sunflower-fm/source/browse/application/plugins/file_lis
t/local_provider.py#56

Line 56 in local_provider.py is no longer "if not tmp.trash()" it's "try:" now. 
So you are starting old code which produces this error. If you just pulled from 
main repository then you did something else wrong as change is there since last 
night.

How did you clone repository?

Original comment by MeanEYE.rcf on 17 Feb 2013 at 12:56

GoogleCodeExporter commented 9 years ago 
mmm hg clone yesterday, hg pull today. hg pull said something like: Adding 5 
change-sets with 4 changes in 4 files..

Now I deleted sunflower-fm/ and hg cloned again. It now works. Strange :/ Sorry 
to bother you.

Original comment by turboos...@gmail.com on 17 Feb 2013 at 1:01

GoogleCodeExporter commented 9 years ago 
Ah, sorry. Should have told me that. :)
After each pull you have to do "hg update" to update all files. Difference 
between git and hg :)

You are not bothering me. :D

Original comment by MeanEYE.rcf on 17 Feb 2013 at 1:04

GoogleCodeExporter commented 9 years ago 
sneaky hg! thanks anyway.

Original comment by turboos...@gmail.com on 17 Feb 2013 at 1:11