search

goodmind / sunflower-fm

Automatically exported from code.google.com/p/sunflower-fm
GNU General Public License v3.0
1 stars 0 forks source link

Bad smart breadcrumbs color calculation on bright themes. #348

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Traverse down the file system to any subfolder. The actual path is being 
correctly updated while getting deeper in the folder structure.
2. Now traverse (back) up the folder structure, use any of the available ways 
(backspace key, arrow key+enter, mouse click). The actual path shows still the 
previous deepest folder you've visited.
3. If you move again down the "folder tree" using the same "branch", the path 
is still not updated until you change the branch.

What is the expected output? What do you see instead?
Expected: show the actual path on each and every move in the folder structure
Instead: the path is updated only when you traverse down to a branch you were 
not previously in

What version of the product are you using? On what operating system?
Sunflower 0.1a (58)
Linux 3.11.0-12-generic #19-Ubuntu SMP Wed Oct 9 16:20:46 UTC 2013 x86_64 
x86_64 x86_64 GNU/Linux
Linux Mint 16 Petra

Please provide any additional information below.
Example:
- Traverse down from /home/userX to /home/userX/pictures/screenshots/2014
 => all is fine
- Go back to /home/userX/pictures
 => path shows still /home/userX/pictures/screenshots/2014
- Go again deeper to /home/userX/pictures/screenshots
 => path shows still /home/userX/pictures/screenshots/2014
- Go now to path shows still /home/userX/pictures/screenshots/2013
 => the path was now updated and shows correctly path shows still /home/userX/pictures/screenshots/2013
- Go back to path shows still /home/userX/pictures
 => path shows still /home/userX/pictures/screenshots/2013
- Go now to  => path shows still /home/userX/pictures/photos
 => the path show now correctly /home/userX/pictures/photos
... etc.

Original issue reported on code.google.com by filiprut on 4 May 2014 at 12:46

GoogleCodeExporter commented 9 years ago 
Can you provide a screen shot. This sounds like an issue with color calculation 
for smart breadcrumbs.

Original comment by MeanEYE.rcf on 4 May 2014 at 12:49

GoogleCodeExporter commented 9 years ago 
Sorry, the last action in my example should be:

- Go now to /home/userX/pictures/photos
 => the path shows now correctly /home/userX/pictures/photos

Original comment by filiprut on 4 May 2014 at 12:50

GoogleCodeExporter commented 9 years ago 
Thanks for such a rapid reply! Here's the screenshot.

Original comment by filiprut on 4 May 2014 at 12:56

Attachments:

GoogleCodeExporter commented 9 years ago 
Yup. It is smart breadcrumbs coloring issue. Can you tell me which theme is 
this?

Original comment by MeanEYE.rcf on 4 May 2014 at 12:57

GoogleCodeExporter commented 9 years ago 
Cinnamon

Original comment by filiprut on 4 May 2014 at 1:33

GoogleCodeExporter commented 9 years ago 
So issue with this in particular is, like I previously mentioned, smart 
breadcrumbs coloring. Smart breadcrumbs show longest previously visited path of 
which the current path is part of. Part of the location should be in different 
color to denote path visited earlier. Due to poor code on my part and bright 
colors of this theme calculated color for showing this is not that much 
different from original text color.

I will accept this bug report and fix the issue. In the mean time you can go to 
Preferences -> Item List -> Breadcrumbs and switch to Normal or None from 
Smart.

Original comment by MeanEYE.rcf on 4 May 2014 at 2:06

GoogleCodeExporter commented 9 years ago 
Thank a lot. You made your point perfectly clear, I checked that again and can 
confirm that it's exactly as you wrote - the colours are different but so 
similar that I wasn't able to recognize that before.
Your proposed solution to set up normal breadcrumb display made the think work 
for me.
Thanks a lot for your perfect support.

Original comment by filiprut on 4 May 2014 at 3:07

GoogleCodeExporter commented 9 years ago 
You are welcome. :) Glad I could help. Thanks for reporting this issue and 
making Sunflower a better program.

Original comment by MeanEYE.rcf on 5 May 2014 at 11:27

GoogleCodeExporter commented 9 years ago 
I've pushed a fix for this issue. Can you please test with repository version. 
You can either clone Mercurial repository from Google Code, or pull from GitHub 
(https://github.com/MeanEYE/Sunflower). Thanks!

Original comment by MeanEYE.rcf on 5 Jun 2014 at 12:10