goodrobots / vision_landing

Precision landing using visual targets
GNU General Public License v3.0
202 stars 71 forks source link

Move to either c++ or python, away from dual/hybrid model #94

Open fnoop opened 6 years ago

fnoop commented 6 years ago

vision_landing is currently a python wrapper/supervisor that talks to dronecode, and calls c++ code for the visual processing. This works, but turns out to be overly complex to coordinate the two halves, and dronecode is very slow/inefficient. As we want to get vision_landing running on much slower platforms -ie. raspberry - migrate to:

kripper commented 1 year ago

C++ is faster, but having a Python wrapper for the high level mavlink communication is not a problem, as long as the IPC (currently using stdout queues) is well designed and abstracted (like a C++ module for Python).

Please note that stdout and stderr lines may arrive in wrong order.

Also see: https://github.com/chobitsfan/apriltag_plnd/issues/1

fnoop commented 1 year ago

C++ is faster If python is fast enough for the job, it's a much more friendly language to code a project like this in, for others who want to experiment/contribute. My personal opinion is c++ should only be used where necessary for uses outside of the main flight controller code, because the number of people who can safely write not-to-buggy-code in c++ is much lower.

kripper commented 1 year ago

Agree.