Start testing against Django 1.11.x series

goodtune / vitriolic

This project unifies the various sub-projects Touch Technology has created over the years that were intended to be reusable in isolation, but in practice never stood alone for long.

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Start testing against Django 1.11.x series #4

Closed goodtune closed 7 years ago

goodtune commented 7 years ago

There is an impending LTS release coming. We know it introduces some new features which we won't have implemented against, however I'm more interested in knowing that we aren't using any deprecated features.

Only as good as our test suite is, which is a separate matter.

goodtune commented 7 years ago

First issue encountered - an ImportError due to removal of undocumented classes.

Changes due to the introduction of template-based widget rendering

Since these were removed lets look at home much the ones we depended upon changed between 1.8 (LTS) and 1.10, and copy it into the project as a compatibility shim.

goodtune commented 7 years ago

We only have one place to fix:

$ ack '(SubWidget|RendererMixin|ChoiceFieldRenderer|RadioFieldRenderer|CheckboxFieldRenderer|ChoiceInput|RadioChoiceInput|CheckboxChoiceInput)' -l
touchtechnology/common/forms.py

We use the following deprecated classes:

$ ack '(SubWidget|RendererMixin|ChoiceFieldRenderer|RadioFieldRenderer|CheckboxFieldRenderer|ChoiceInput|RadioChoiceInput|CheckboxChoiceInput)' -oh | sort -u
CheckboxFieldRenderer
ChoiceFieldRenderer
RadioChoiceInput
RadioFieldRenderer