search

goodwill / capybara-select2

Helper for capybara to be able to trigger select on select2 javascript (needed for js enabled test only)
MIT License
80 stars 111 forks source link

use find instead of first to support waiting #37

Closed machisuji closed 9 years ago

machisuji commented 9 years ago

otherwise selecting anything during a slow run may fail

At OpenProject we have some specs involving select2 which keep failing randomly. We think it's due to capybara-select2 using first instead of find. This always works locally where it's fast. But in potentially slow runs (e.g. on travis) it fails every now and then.

Was there a specific reason you chose first over find here or do you think one could just use find to sovle our problems?

We're still waiting for the latest CI results to be able to confirm if this change helped us or not. Will update.

divineforest commented 9 years ago

@machisuji it's just a bug that there is first instead of find. Please confirm, that everything is ok for now and we can merge this.

machisuji commented 9 years ago

@divineforest Both travis and our own CI look good. No more failures involving select2.

divineforest commented 9 years ago

@machisuji thanks :)