Manifest Redesign - Githubissues

goodybag / cater-api-server

hacking this together as fast as possible but with an eye for re-organization

1 stars 0 forks source link

Manifest Redesign #2322

Closed L8D closed 8 years ago

L8D commented 8 years ago

[x] Initial design
[x] Header formatting changes
[x] Table cell border rendering bugs
[x] Fix font issues
[x] Fix flex-box issues
[x] Get accurate font size ratios

L8D commented 8 years ago

@john yesterday it seemed like you had gotten something slightly working with PhantomJS 2. Can you let me know what progress you made on that so I can look into finalizing the fix myself and getting this merged by/on Monday?

jrf0110 commented 8 years ago

I just followed some of the stuff here:

https://github.com/ariya/phantomjs/pull/14085#issuecomment-204483473

Specifically, the viewportSize advice

L8D commented 8 years ago

K so I got into it and the problem stemmed from the viewport size being inaccurate and accommodating for the margins that are actually being overridden by the command line flags. Calculating the viewport size for a DPI of 96 and tweaking some of the order manifest CSS got it to work. I also reverted to the old-school flex boxes to get those to render correctly in phantom (even though everyone on the internet says phantom.js v2 supports flexboxes).

mic drop

L8D commented 8 years ago

We need to test the other PDFs to make sure that the gen-pdf changes work. Then we need to setup Heroku to use PhantomJS 2.0

L8D commented 8 years ago

This has been confirmed by Gillian and should be good to go