search

goodybag / cater-api-server

hacking this together as fast as possible but with an eye for re-organization
1 stars 0 forks source link

Consider renaming `Order Params` to `Search Params` #623

Open jrf0110 opened 10 years ago

jrf0110 commented 10 years ago

It's just confusing, because it barely has anything to do with an order. It's about searching for restaurants.

prestonp commented 10 years ago

I would agree that they are used for searching but they do make a way into the actual order. If you set your params, the order is initialized with them

prestonp commented 10 years ago

Actually, in the context of searching, it does make more sense to name them search params. They just become order properties when adding items

jrf0110 commented 10 years ago

The problem is that the name Order Params is pervasive. This would be a huge change, but I think in the long run will help us properly conceptualize our application code.

lalitkapoor commented 10 years ago

:+1: