goodybag / lunchroom

Daily meal deals
https://lunchroom.goodybag.com
0 stars 0 forks source link

[Final-Post-Launch] App Tweaks #41

Closed cadorn closed 8 years ago

cadorn commented 9 years ago

$feature https://github.com/goodybag/lunchroom/issues/1

Landing

cadorn commented 9 years ago

Prioritized functionality:

After that ^^ next things to do:

jrf0110 commented 9 years ago

Photos should present well in each size

we'll just need separate photos for the item tiles and the modal view. Currently, the design has a different aspect ratio for the Order Review, but we'll just make them the same as item modal.

So, tile_photo_url and photo_url columns, where photo_url is the square version

jrf0110 commented 9 years ago

Photos should present well in each size

I suppose we could add that to the existing item schema in Cater, however, I feel that it's outside of Cater's domain. If we can come up with good enough semantic names, I guess it works. photo_url_landscape photo_url_square - but those are somewhat misleading

cadorn commented 9 years ago

@jrf0110 If you can get all UI work for user/card management done today (and remaining UI work above) I'll setup the account component UI as a test later today ready to implement tomorrow; Today I will focus on advanced orders and various other smaller issues. Sound good?

cadorn commented 9 years ago

@jrf0110 FYI: Did not get to advance ordering today but everything is prepared to move forward if there are no more issues in the morning.

cadorn commented 9 years ago

Logs for staging and production are now on loggly. Client logs errors and debug statements; backend logs everything for now. (Will be deployed with payments update).

cadorn commented 9 years ago

@L8D I found the order submission bug in the process of implementing advance ordering. It should no longer happen after next update and all server errors will now show on client submission form. I think it was caused by old event links.

cadorn commented 9 years ago

@jrf0110 @jpanchal13 I have a preview of advance ordering ready to upload to staging tomorrow morning after ordering has started on production and we can use staging for testing. The functionality on the app side should be complete (I have not done final polish walkthrough), most backend work is done but I still need to update the order display in admin and deal with order delivery emails differently. Getting multi-day ordering to work turned out to be a lot of work that touched the whole flow and data model and I wish I would have added that from the start. I am glad I decided to do some refactoring work along with the advance ordering as I had to touch everything again anyway and it dramatically simplified things and will make adding user accounts much easier now. Logging is also in and various better error catching during order process. After I push to staging tomorrow morning I would like to get feedback on app by the afternoon so I can finish this update tomorrow ready for Wednesday morning. (preview PR: https://github.com/goodybag/lunchroom/pull/46)

cadorn commented 9 years ago

@jrf0110 @jpanchal13 update pushed to staging; I have yet to hook in new checkout validation and send delivery emails; everything else related to advance ordering is done; I have added a better testing system. You can now go to this URL to enable pre-filling the checkout form with test data: http://staging.lunchroom.goodybag.com/?TEST_USER_KEY=3FEB7109-9F4B-4757-A530-7FE7FD6E3130 (link also in goodybag-core project) Go to the URL again with a different value for the test key to disable again. This works for staging and will work on live.

cadorn commented 9 years ago

Advance order issues:

cadorn commented 9 years ago

Fixes:

cadorn commented 8 years ago

Moved: https://github.com/goodybag/lunchroom.goodybag.com/issues/8