[feat] Allow user to set some other vairables.

goofball222 / murmur

Murmur server (Mumble) Docker container - https://mumble.info

Apache License 2.0

36 stars 14 forks source link

[feat] Allow user to set some other vairables. #3

Closed m0wer closed 3 years ago

m0wer commented 5 years ago

Fixes #2 .

Changes proposed in this pull request:

New available env vars in the stable release:
- BASEDIR
- CERTDIR
- CONFIGDIR
- DATADIR
- LOGDIR

If you like this approach, I can add this same changes to the other versions (rc, snapshot...) and to the README.md

@goofball222

m0wer commented 5 years ago

I added the variables to every Dockerfile and their description and default values to README.md.

m0wer commented 4 years ago

@goofball222 this MR shouldn't be merged anymore since more changes where made to the fork. I'll open a new one if you are willing to merge it.

I don't understand why such a simple MR is taking so long... It just adds a few variables that have the same default values as before so it doesn't affect the users who don't want to change them.

Any feedback would be appreciated.