Do not run nightly workflows on forks.

google-ai-edge / ai-edge-torch

Supporting PyTorch models with the Google AI Edge TFLite runtime.

Apache License 2.0

228 stars 26 forks source link

Do not run nightly workflows on forks. #15

Closed advaitjain closed 2 months ago

advaitjain commented 2 months ago

This change can't really be tested until:

it is merged: to make sure nothing breaks for the upstream repo
forks update to upstream/main: to confirm that workflows are not triggered in forks.

BUG=cleanup github workflows.

chunnienc commented 2 months ago

I thought workflows are disabled by default in github forked repo, and fork owner can disable per-workflow in their settings after enabling the feature. Maybe better for me to understand what issues you saw for this.

advaitjain commented 2 months ago

I should have provided more context with the PR.

Workflows appear to be enabled by default in forks. For example: https://github.com/advaitjain/ai-edge-torch/actions

Anyone forking does have the option of disabling then, but that isn't great either. It's an additional step that can easily be overlooked (as I did). And I might want to test some workflow in my fork.

The approach from this PR is what we use with TensorFlow as well.

chunnienc commented 2 months ago

The message I saw in the actions page in my fork repo is this though (https://github.com/chunnienc/ai-edge-torch/actions):

Workflows aren’t being run on this forked repository Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

I think this change is fine as it won't affect our dev flow and tensorflow uses this approach. Let's proceed with this.