search

google-ai-edge / ai-edge-torch

Supporting PyTorch models with the Google AI Edge TFLite runtime.
Apache License 2.0
228 stars 26 forks source link

remove trailing comment in workflow files #16

Closed advaitjain closed 2 months ago

advaitjain commented 2 months ago

https://github.com/google-ai-edge/ai-edge-torch/pull/15 was attempting to prevent nightly workflows from running in forks.

However, the yaml was incorrectly formatted, which gave the following error (workflow_dispatch log):

Invalid workflow file: .github/workflows/nightly_pip_test.yml#L19
The workflow is not valid. .github/workflows/nightly_pip_test.yml (Line: 19, Col: 9): Unexpected symbol: '#'. Located at position 134 within expression: github.event_name == 'workflow_dispatch' ||
(github.event_name == 'schedule' && github.repository == 'google-ai-edge/ai-edge-torch') # don't run in forks.

This PR is removing the trailing comment and has been verified to work by running the workflow via dispatch from my branch in my fork (log).

BUG=fix broken workflow.

image

advaitjain commented 2 months ago

I'm going to merge without code reviews to get the change in so that I can verify manually and also see the results of the nightly run.