google-ai-edge / mediapipe

Cross-platform, customizable ML solutions for live and streaming media.
https://ai.google.dev/edge/mediapipe
Apache License 2.0
26.85k stars 5.09k forks source link

channel error when using bilateral_filter_calculator #2310

Closed carter54 closed 3 years ago

carter54 commented 3 years ago

Hi there,

I tried to add the bilateral filter in my segmentation task. Following channel number error raise:

"CPU filtering supports only 1 or 3 channel input images."

I checked my input channel is 1 (output from selfie segmentation task)...

Then I found this line in bilateral_filter_calculator.cc https://github.com/google/mediapipe/blob/ecb5b5f44ab23ea620ef97a479407c699e424aa7/mediapipe/calculators/image/bilateral_filter_calculator.cc#L243 It seems like a "!“ is missing in the code.

mcclanahoochie commented 3 years ago

Hi, Thanks for bringing this to our attention. This is indeed a bug, and has now been fixed upstream. The next release of MediaPipe should contain the update. Cheers

sgowroji commented 3 years ago

Hi @carter54, From the above comment we are closing this issue as of now and I would request you to test the above once the new release roll out. Reach us back if you still face the same.

google-ml-butler[bot] commented 3 years ago

Are you satisfied with the resolution of your issue? Yes No