search

google-ai-edge / mediapipe

Cross-platform, customizable ML solutions for live and streaming media.
https://ai.google.dev/edge/mediapipe
Apache License 2.0
27.81k stars 5.18k forks source link

Why can't use holistic landmarker in C++ ? #5172

Open endink opened 9 months ago

endink commented 9 months ago

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)

None

OS Platform and Distribution

Windows x64

MediaPipe Tasks SDK version

0.10.10

Task name (e.g. Image classification, Gesture recognition etc.)

holistic_landmarker_graph

Programming Language and version (e.g. C++, Python, Java)

C++

Describe the actual behavior

No holistic landmarker

Describe the expected behaviour

We need holistic landmarker

Standalone code/steps you may have used to try to get what you need

holistic_landmarker_graph is an internal "cc_library"

Even webassembly/typescript can use holistic landmarker, but holistic_landmarker_graph visibility is internal for C++, as C++ developers, we accept that there is no documentation, there is no valuable feedback in github issue , we read the test code ourselves to use the new features. But now, even compilation is blocked for C++, we have to manually modify the BUILD visibility, this is a C++ project. Incredibly, C++ developers are low-class citizens in this project!

schmidt-sebastian commented 8 months ago

C++ is not considered a public facing API for MediaPipe Tasks yet. I will change the build rules to public for now. We will eventually add a C++ API as well.