search

google-apis-rs / google-cloud-rs

Asynchronous Rust bindings for Google Cloud Platform APIs.
176 stars 48 forks source link

Make reqwest as optional #20

Closed lht closed 4 years ago

lht commented 4 years ago

This patch makes Reqwest optional if feature storage is not enabled. Also set default_features to false to avoid pulling openssl.

This patch also bumps Tonic to 0.3.0, otherwise two versions of tokio-rustls and rustls will be included.

Hirevo commented 4 years ago

Thank you for the pull request.

Yes, it's true that reqwest can be a large dependency to pull in and can feel not justified when only using gRPC-based services like Pub/Sub.
I am not familiar about using hyper directly, so thank you for this work.

While the CI wasn't able to test the PR, I ran the tests on my machine and they all passed.
So, I think we can go forward with this.

Thanks again for the PR !