google-apis-rs / google-cloud-rs

Asynchronous Rust bindings for Google Cloud Platform APIs.
176 stars 48 forks source link

Replace `googleapis/googleapis` submodule by vendoring the needed files #27

Closed Hirevo closed 4 years ago

Hirevo commented 4 years ago

This PR is an attempt to fix the issue observed in #24 and #26, where the googleapis/googleapis submodule is painfully long to clone, which considerably slows down any build from source.

So, this PR removes the googleapis/googleapis submodules and replaces it with a regular directory in which we vendor the files we need from that repository (being the protobuf definitions) and its LICENSE file, since we are not the authors of these files.

Hirevo commented 4 years ago

The last traces of the submodule have now been removed and everything still build and run as expected.
So, I think this PR is ready to be merged ! 🎉