google-ar / WebARonARCore

An experimental Chromium modification in the form of an app for Android that lets developers build Augmented Reality (AR) experiences using web technologies on top of Google's ARCore.
https://developers.google.com/ar/develop/web/getting-started
Apache License 2.0
756 stars 115 forks source link

Parity with WebARonARKit: addAnchor, exposed identifier, add/remove anchor events. #37

Closed judax closed 6 years ago

judax commented 6 years ago

Changed the createAnchor to addAnchor. Added events for add and remove anchors. Exposed the identifier to the VRAnchor.

Change-Id: Iab117b6a4052aa33cff09ccc61d595bb7f7e302f

judax commented 6 years ago

I think I have fixed all the indentation issues in the files pointed out in the review. Thanks for the comments and taking the time to review! I will try to improve this in the future.