Closed roelkok closed 6 years ago
It seems the library that is being used to access the camera frame is failing on the Samsung Galaxy S8. I will try to get my hands on a device a test it to try to resolve the issue. Thanks for reporting.
same problem on same device. I get the message "webarcore keeps stopping"
@robertjuh In case this is blocking you, I got the apk from an random older commit (22b75c18d4aeb4232e47556cc27f067f4115c75b) and that one works for me.
Thanks a lot Roel! Works for me too!
Ok, I finally got a S8 to test with and I tested the latest APK in the webarcore_57.0.2987.5 branch and it does not crash. Could it be that the S8 GPU is different?
Ok, confirmed. It is something that happens in some S8s (mainly Asian version of S8) because of the GPU they use. Working on a fix. Sorry for the inconveniences.
First of all sorry for the delay on this. I am working on a temporary solution. This solution, if it works, it will disable marker detection. Would that work for you? As I mentioned, it is a temporary solution.
Thanks for picking this up. I'm not sure what marker detection means in this case. Recognizing a predefined image for tracking the camera position like old school ar? Or is it being able to place an anchor on a plane and track that in space?
In my opinion, besides positional tracking of the camera, plane detection is a very essential part of the app. I think it would be confusing for devs if plane detection wouldn't work on a specific device.
Marker detection is a new feature we have added to WebARonARCore. Apart from pose tracking and plane detection, the system is also able to detect markers upon request (QRCodes and special AR markers) that can be useful. This crash is related to how this feature is currently implemented. The fix would make the feature only to kick in (initialize) if marker detection is requested and thus, I hope, solve the problem. Tracking, planes and the new anchors would still work, just that if you try to use the marker detection feature, the app is very likely to keep crashing.
We have a solution for it too but it will take some time and thus, I preferred to have this patch added so at least you can use the basic browser prototype working on those specific S8 devices that crash.
Please, test PR #51 and let me know if the app still crashes. I do not own an specific S8 device with the chipset that makes the app to crash. Thanks in advance!
@judax 's fix works on SM-G950F (Australian release), on which the observed bug occurs.
Works here too!
Thank you for testing it. As soon as a review give the PR a thumbs up, it will land.
The PR #51 has landed. Closing.
The WebARCore app crashes whenever I try to load one of the samples from the ' Getting Started with AR on the Web' page. I'm using the most recent ARCore and WebARCore apks
Device: Samsung S8 (SM-G950F) Android 7.0 Build number NRD90M.G950FXXU1AQI7
This is what appears in Logcat when the app crashes.