google-ar / WebARonARCore

An experimental Chromium modification in the form of an app for Android that lets developers build Augmented Reality (AR) experiences using web technologies on top of Google's ARCore.
https://developers.google.com/ar/develop/web/getting-started
Apache License 2.0
756 stars 115 forks source link

Galaxy S7 support #55

Closed urish closed 6 years ago

urish commented 6 years ago

Seems like Galaxy S7 is now officially supported by ARCore: https://developers.google.com/ar/discover/#supported_devices

Is it also supported by WebARonARCore? If so, do would you like me to send a PR to update the list of supported devices in README?

judax commented 6 years ago

Thank you for the note. What is happening is that WebARonARCore is based on ARCore DP1 (were only Pixel devices and S8 were supported). DP2 now supports more devices. The biggest problem is that adding DP2 support internally requires significant changes. We are studying some possible solutions. We will update this issue as we find the right solution.

urish commented 6 years ago

Thank you so much!

I really admire your work on this project, and I am very excited about the endless possibilities it will create for authoring cross-platform AR content for the web. I even created a detailed step-by-step tutorial guiding fellow developers how to use this magical technology:

https://medium.com/@urish/web-powered-augmented-reality-a-hands-on-tutorial-9e6a882e323e

As soon as DP2 support lands, I will update my tutorial to reflect the new supported devices.

Thanks again, and keep up the good work!

judax commented 6 years ago

57 has landed already. Please, be mindful that the current version of WebARonARCore is not built against the ARCore 1.0 SDK. Still, as the communication bridge between the API and the ARCore service is the same, it seems to be working well. We are working on a major reimplementation of this whole project on top of the latest Chromium and ARCore. ETA still TBD.