search

google-ar / WebARonARCore

An experimental Chromium modification in the form of an app for Android that lets developers build Augmented Reality (AR) experiences using web technologies on top of Google's ARCore.
https://developers.google.com/ar/develop/web/getting-started
Apache License 2.0
756 stars 115 forks source link

Removed the supported device check to enable WebARonARCore to run on … #57

Closed judax closed 6 years ago

judax commented 6 years ago

…any device as ARCore DP2 has support for more devices now. Reported issues: #55 and #52 are related to it.

The main idea behind this change is to enable more (actually all) devices to execute WebARonARCore. The current implementation of WebARonARCore is based on ARCore DP1 and the call to check the supported devices only verifies the initial DP1 supported devices. ARCore DP2 supports a wider number of devices and until we do not update WebARonARCore to DP2 completely (we are working on it) we won't be able to compare with the new list. Some users are indicating that WebARonARCore is stating that their devices are not supported when DP2 says they should be supported. I have tested all our demos with WebARonARCore built on top of DP1 using ARCore DP2 APK and it works fine. This PR is trying to improve the situation in the interim while the proper ARCore DP2 implementation is done.

urish commented 6 years ago

Seems like ARCore 1.0 has been released with even more supported device: https://www.blog.google/products/google-vr/announcing-arcore-10-and-new-updates-google-lens/amp/

Any chance to get the prebuilt APK updated with this PR ?

urish commented 6 years ago

Now that this has landed, perhaps it will make sense to update the supported device list in the README?