google-ar / WebARonARCore

An experimental Chromium modification in the form of an app for Android that lets developers build Augmented Reality (AR) experiences using web technologies on top of Google's ARCore.
https://developers.google.com/ar/develop/web/getting-started
Apache License 2.0
756 stars 115 forks source link

Add support for ARCore 1.0 #61

Open Nigel-Burton opened 6 years ago

Nigel-Burton commented 6 years ago

Hi @judax I'm working with Pixel 2 XL with 1.0 installed (2/23/18) - It shows "ARCore not installed" with WebARonARCore but works fine with unity builds. thanks

cvasquez-github commented 6 years ago

Same here! Trying to run it on Galaxy S7 only supported on the latest ARCore 1.0. Could you please support ARCore 1.0? Thank you very much!

screenshot_20180301-131755

screenshot_20180301-131830

hschamberlin commented 6 years ago

Also having the same problem running the demo's though a pixel2

judax commented 6 years ago

I have been trying to reproduce this issue and I haven't been able. I have uninstalled ARCore and WebARonARCore and install them from Google Play (ARCore) and the link in the README (WebARonARCore) and I am able to get the app to work correctly. Both on Pixel 1 and 2.

Could you provide the ARCore version? Mine is 1.0.180129253

Thank you.

judax commented 6 years ago

Do you mind trying the following?

  1. Install this APK: https://github.com/google-ar/arcore-android-sdk/releases/download/sdk-preview/arcore-preview.apk
  2. Test again.
Vavoo commented 6 years ago

Tested on Pixel 2: Work well with arcore-preview. Doesn't work with ARCore 1.0.180129253 (ARCore not installed message).

Tested on Samsung S7: Doesn't work with arcore-preview (Tango crash all the time). Doesn't work with ARCore 1.0.180129253 (ARCore not installed message).

cvasquez-github commented 6 years ago

Well, arcore preview officially does not support Galaxy S7, only 1.0, and WebARonCore is based on ARCore preview so it wont work with arcore 1.0 on any device...

-- Carlos Vasquez Coiron, Inc

www.coiron.com

Mobile: +1 949 636 6106 Skype: carlos.vasquez.saez Skype In US: +1 949 391 3836 Skype In Chile: +56 2 25709617

CONFIDENTIAL NOTE: The information transmitted in this message and/or attachments is confidential and is intended only for use of the person or entity to whom it is addressed. If you are not the intended recipient, any retention, dissemination, distribution or copy of this information is strictly prohibited and sanctioned by law. If you received this message in error, please reply us this same message and delete this message and all attachments. Since integrity of electronic mail cannot be guaranteed, Coiron shall not be responsible if the contents of this message and/or its attachments should be modified or altered in any manner. Thank you for your attention to this matter.

NOTA DE CONFIDENCIALIDAD: La información contenida en este mensaje y/o en los archivos adjuntos es de carácter confidencial y está destinada al uso exclusivo del emisor y/o de la persona o entidad a quien va dirigida. Si usted no es el destinatario, cualquier almacenamiento, divulgación, distribución o copia de esta información está estrictamente prohibido y sancionado por la ley. Si recibió este mensaje por error, por favor infórmenos inmediatamente respondiendo este mismo mensaje y borre éste y todos los archivos adjuntos. Considerando que no existe certidumbre de que el presente mensaje no será modificado como resultado de su transmisión por correo electrónico, Coiron no será responsable si el contenido del mismo ha sido modificado. Por su atención, gracias.

On Mar 19, 2018 7:57 AM, "Yoav Karpeles" notifications@github.com wrote:

Tested on Pixel 2: Work well with arcore-preview. Doesn't work with ARCore 1.0.180129253 (ARCore not installed message).

Tested on Samsung S7: Doesn't work with arcore-preview (Tango crash all the time). Doesn't work with ARCore 1.0.180129253 (ARCore not installed message).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/google-ar/WebARonARCore/issues/61#issuecomment-374241739, or mute the thread https://github.com/notifications/unsubscribe-auth/AZr4ksDpO21tf3cKmFrIBTMwvt3bpfQMks5tf8dcgaJpZM4SSIFZ .

hschamberlin commented 6 years ago

@judax Using the APK you linked and re-installing web on ar core i have been able to get the demos functioning. Currently i have version 1.0.180129153 of arcore installed

judax commented 6 years ago

The current version of WebARonARCore uses ARCore dev preview 1 so that is why that APK is the one needed. We are working on rebuilding WebARonARCore in many fronts and one of them will be resolving this. Stay tuned and sorry for the inconveniences...

vincentfretin commented 6 years ago

@StudioZAAK Like @judax said, WebARonARCore uses ARCore dev preview 1, so no support for S7 right now, only S8 and Pixel. You will have to wait a new WebARonARCore version supporting latest ARCore.

rohann9 commented 6 years ago

Please modify the ARCore 1.0 like preview mod apk for unsupported devices. Every app demands ARCore 1.0 to work. So, Preview ARCore mod apk isnt of any use now.

judax commented 6 years ago

Sorry. This project is based on ARCore Developer Preview. We are actively working on updates but there is no ETA. Sorry for the inconveniences.

rohann9 commented 6 years ago

So, is there any project based on official release of ARCore v1 ?

judax commented 6 years ago

The new update will be up to date to any ARCore release from now on. We have learned much from these prototypes and are working on an improved revision.

judax commented 6 years ago

68 has landed. Closing for now. Feel free to reopen if you need to.

carstenschwede commented 6 years ago

@judax Could we leave this open until support for ARCore 1.0 has landed?

rohann9 commented 6 years ago

where the updated version will be found ?

robertjuh commented 6 years ago

Right here probably. I'm sure that when you get a notification of this issue being closed that you'll be able to download the newest version from this GiT. For now, patience :)

rohann9 commented 6 years ago

So, will the upcoming version support my redmi note 3 ?

robertjuh commented 6 years ago

Here you can see a list of supported devices that the newest ARCore version has: https://developers.google.com/ar/discover/

Asus Zenfone AR ASUS_A002, JP_ASUS_A002, VZW_ASUS_A002A
Asus ZenFone Ares ASUS_A002_2
Google Pixel 2 All models
Google Pixel 2 XL All models
Google Pixel All models
Google Pixel XL All models
Huawei P20 EML-L29, EML-L09, EML-AL00, EML-TL00
Moto Z2 Force nash
OnePlus 5 ONEPLUS A5000
Samsung A5 SM-A520F, SM-A520X, SM-A520F, SM-A520W, SM-A520K, SM-A520L, SM-A520S
Samsung A7 SM-A720F, SM-A720F, SM-A720X, SM-A720S
Samsung A8 SM-A530W, SM-A530X, SM-A530F, SM-A530N
Samsung A8+ SM-A730F, SM-A730X
Samsung Note8 SM-N9508, SM-N950F, SM-N950N, SM-N950U, SM-N950W, SM-SC01K, SM-SCV37
Samsung S7 SM-G930A, SM-G930F, SM-G930K, SM-G930L, SM-G930P, SM-G930R SM-G930S, SM-G930T, SM-G930U, SM-G930V, SM-G930W
Samsung S7 Edge SM-G935A, SM-G935F, SM-G935K, SM-G935L, SM-G935P, SM-G935R, SM-G935S, SM-G935T, SM-G935U, SM-G935V, SM-G935W, SM-SCV33, SM-SC02H
Samsung S8 SM-G950U, SM-G950N, SM-G950F, SM-G950W, SM-G9508, SM-SCV36, SM-SC02J
Samsung S8+ SM-G955F, SM-G955N, SM-G955U, SM-G955W, SM-SC03J, SM-SCV35
robertjuh commented 6 years ago

And in the current version that WebAROnARCore supports, this list is about 75% smaller.

What you could try is to remove the 'check' where arcore looks for your device ID, i dont have it on me but you could find it by looking for "enable arcore anywhere" or "arcore on any device" or something. But anyway this will mean that the callibration data is inadequate and the model will probably float around like crazy.

rohann9 commented 6 years ago

But ARCore will not work without my device's calibration file ? so. how to get it work ?

judax commented 6 years ago

The check for the supported device has been lifted but as you mention, that does not mean that you will get correct tracking. Please, remember that this prototype is currently outdated and only supports Developer Preview 1 (and that you need yo have the ARCore DP1 APK installed along with WebARonARCore). No ETA on when we will update this project, sorry. We are actively working on it.

rohann9 commented 6 years ago

so the upcoming version will not work on my redmi note 3 due to missing calibration file for my device ?

judax commented 6 years ago

You should always check the list of ARCore supported devices: https://developers.google.com/ar/discover/

rohann9 commented 6 years ago

okay..so, how to get it to work on my redmi note 3 ?

judax commented 6 years ago

I guess you will have to wait and see if there is support for ARCore on that specific device in the future. Sorry, cannot provide any other answer for now.

rohann9 commented 6 years ago

And if there isn't ?

Indashio commented 6 years ago

Why it still working on Tango ? Not on ARcore? Please update web ar to ARcore 1.2

judax commented 6 years ago

We are working on a completely new version of this project. Stay tuned. All these issues (and more) should be solved when the new version comes out. Sorry, no ETA yet.

constructive-realities commented 6 years ago

It's late June now, Is there a different approach to do WebAR with arcore now?

msimpson commented 6 years ago

@constructive-realities At this point I'm assuming the upcoming WebXR implementation in Chrome will subsequently be supported by three.ar.js at some point and that will become the different/mainstream approach for WebAR on Android.

However, I believe @judax is referring to the fact that the WebARonARCore code base is being updated to support a newer fork of Chrome while simultaneously implementing ARCore 1.2 features.

Although, this is all conjecture on my part as I'm not on the inside of any of these projects.

judax commented 6 years ago

Correct, our approach will be to provide tools based on standards as much as possible. These projects were prototypes to learn and experiment.

WebXR is now slowly adding AR capabilities and we have released a version of Chrome Canary with the initial experimental APIs for hit testing. You can learn more in this post: https://developers.google.com/web/updates/2018/06/ar-for-the-web

About this repo, we are working on a replacement that hopefully will address many of the concerns posted in the issues. The main idea will be to be able to still build WebXR based web applications using a more native and experimental approach than with browsers. Stay tuned!