Unnecessary "android.permission.READ_PHONE_STATE" Added

google-ar / arcore-unity-sdk

ARCore SDK for Unity

https://developers.google.com/ar

Other

1.4k stars 400 forks source link

Unnecessary "android.permission.READ_PHONE_STATE" Added #449

Open dcannizzaro opened 5 years ago

dcannizzaro commented 5 years ago

The lack of min SDK in the androidManifest.xml of the arcore_unity.aar file seems to cause an unnecessary "android.permission.READ_PHONE_STATE" to be added to the merged manifest on build.

fredsa commented 5 years ago

Closing as this issue is missing key information to help us reproduce it.

Unity version
ARCore SDK for Unity version
Device manufacturer, model, and O/S
ARCore APK installed version: On Windows, use: adb shell pm dump com.google.ar.core | findstr /i "packages: versionName" On macOS, use: adb shell pm dump com.google.ar.core | egrep -i versionName\|packages:
Output of adb shell getprop ro.build.fingerprint

enpela commented 5 years ago

I was troubled with the same phenomenon.

However, by editing arcore_unity.aar and adding targetSdkVersion and minSdkVersion to androidManifest.xml, I was able to remove READ_PHONE_STATE. Thank you.

The only way to reproduce is to build the sample attached to ARCore 1.6.0 for Android.

fredsa commented 5 years ago

Reopening after verifying that READ_PHONE_STATE is being added to the final manifest when it should not be. Agreed that this is due to missing android:minSdkVersion declaration.

fredsa commented 5 years ago

We hope to fix this as part of the 1.8.0 release.