search

google-ar / sceneform-android-sdk

Sceneform SDK for Android
https://developers.google.com/sceneform/develop/
Apache License 2.0
1.22k stars 606 forks source link

Migrate to androidx #1031

Open anacoimbrag opened 4 years ago

anacoimbrag commented 4 years ago

Since this project now is opensouce (thanks for it), I had lot of issues placing it in my project with androidx. I've done the migration in my fork, is the project accepting pull requests for this?

vortice3D commented 4 years ago

Hi Ana:

Have you done a comprehensive battery of tests with your migration to AndroidX? Is it production-level stable at the moment?

Best regards.

tellypresence commented 4 years ago

@vortice3D Anecdotally I use @anacoimbrag fork and have had no problems since I started using it (several weeks ago now) -- but of course looking forward to both of

vortice3D commented 4 years ago

Thanks for the feedback @tellypresence.

I'm also using it at the moment without problems except for the 1.16.0 version issues.

Best regards.

anacoimbrag commented 4 years ago

Hi @vortice3D I haven't tested enough to be sure it's production ready, but I didn't know you were accepting PRs. I can do this and get back here 😊

vortice3D commented 4 years ago

Hi @anacoimbrag.

Well, we were in a hurry with a production development app where we needed to use AndroidX, and so your PR was very convenient indeed.

For your information, it has been tested in a very intensive way with not special issues (apart from the usual 1.1.6.0 ones) so for us is completely OK for production.

Said that, the release of the next SDK version must be on its way down (maybe a major upgrade coinciding with the Google IO), and we suppose they are adding AndroidX support among a lot of other things that 1.16.0 version didn't implement in a very polished way.

Best regards.

anacoimbrag commented 4 years ago

@vortice3D thanks for the feedback! I'm very happy to hear it.

But I really hope they are working on new releases, especially because there's not going to be Google IO this year (https://events.google.com/io/).