google-ar / sceneform-android-sdk

Sceneform SDK for Android
https://developers.google.com/sceneform/develop/
Apache License 2.0
1.23k stars 604 forks source link

Dynamic features support bug. #356

Closed istima closed 5 years ago

istima commented 5 years ago

Sceneform doesn't work in dynamic features due to its way of addressing resources. Unable to load Texture registryId='android.resource://com.arfeature.arprofile/drawable/sceneform_plane' java.util.concurrent.CompletionException: java.lang.IllegalStateException: java.io.FileNotFoundException: No package found for authority: android.resource://com.arfeature.arprofile/drawable/sceneform_plane java.util.concurrent.CompletionException: java.io.FileNotFoundException: No package found for authority: android.resource://com.arfeature.arprofile/raw/sceneform_plane_shadow_material

Demo project with proper resource addressing and demo of the issue: https://goo.gl/GmufL3

This is a follow-up to https://github.com/google-ar/sceneform-android-sdk/issues/33 that was closed claimed the issue was fixed while it wasn't.

kunalmshah85 commented 5 years ago

I am running in to same issue. Were you able to find any solution/ work around for this ?

istima commented 5 years ago

@kunalmshah85 nope, not yet. Still waiting for @tpsiaki or @abramyan for comment :(

rozag commented 5 years ago

We have the same issue. Looks, like nobody is going to fix that :(

abramyan commented 5 years ago

Sorry about the late response. We're looking into it.

istima commented 5 years ago

Thanks, Lucy! @abramyan If you'll have any questions - feel free to ask here or reach me out via email, I'd be happy to help.

kunalmshah85 commented 5 years ago

Thanks Lucy @abramyan for looking in to this. my scenario is little bit different than what @istima has. My "Dynamic feature" module is just a facade which is dependent on xyz.aar and xyz.aar is using scene form. my base module downloads dynamic feature at run time which brings in aar with sceneform code along with it. This scenario also results in to same error.

kunalmshah85 commented 5 years ago

@tpsiaki @abramyan. Thanks for looking in to this and identifying it as bug. Would you guys be able to share details around time line for this bug fix. or do you guys have any suggestions or workarounds on how to use Sceneform sdk and ArFragment with dynamic feature. we are working on AR project where we would like to leverage power of Dynamic Feature to reduce app size. if you can share timeline for this for this bug fix it would help us to better plan our project.

istima commented 5 years ago

@tpsiaki @abramyan I"m joining to the question @kunalmshah85 asked.

malik-at-work commented 5 years ago

Fixed in 1.6

coolrukshan commented 4 years ago

I receive an error "com.google.ar.core.exceptions.FatalException: Application manifest must contain meta-data com.google.ar.core" when using ARCore in my dynamic feature module.