google-ar / three.ar.js

A helper three.js library for building AR web experiences that run in WebARonARKit and WebARonARCore
https://developers.google.com/ar/develop/web/getting-started
Apache License 2.0
2.91k stars 365 forks source link

Changes to support ARKit exposing the camera frames #100

Closed judax closed 6 years ago

judax commented 6 years ago

and rendering them in ARView.

Changes Proposed:

ARView now is able to determine if iOS is exposing the camera frames and render them similarly as how WebARonARCore does (but using the correct sampler and texture targets, not the external image OES extension)

Fixes:
Checklist:
judax commented 6 years ago

Pushed some changes to adapt to the WebARonARKit review.

jsantell commented 6 years ago

Nit: linting failure in ARView: 267:54 error Trailing spaces not allowed no-trailing-spaces

judax commented 6 years ago

Pushed a new revision addressing some of the concerns by @jsantell (that should be enjoying his PTO!!!)