google-ar / three.ar.js

A helper three.js library for building AR web experiences that run in WebARonARKit and WebARonARCore
https://developers.google.com/ar/develop/web/getting-started
Apache License 2.0
2.91k stars 367 forks source link

Keep webpack #62

Closed lunzhang closed 6 years ago

lunzhang commented 6 years ago

Is it possible to keep webpack for development purposes and use rollup just for production build.

jsantell commented 6 years ago

Two different pipelines would be harder to maintain and ensure we're getting the same content in both dev and production -- may I ask why the Webpack preference? The only dev facing change is the lack of webpack-dev-server, but something similar can be implemented with something like rollup-plugin-serve

lunzhang commented 6 years ago

I wanted to keep webpack-dev-server for serving so it's easier to access from my phone. Didn't know about the plugin.

jsantell commented 6 years ago

The rollup patch has been bitrotting for a bit so just wanted to get it in, but I can look into adding rollup-plugin-serve as well. In the mean time, running npm run watch with something like simplehttpserver to serve content will get the same functionality as before