continue committing after binary content exception

google-cloudsearch / norconex-committer-plugin

Google Cloud Search Norconex HTTP Collector Indexer Plugin

Apache License 2.0

5 stars 7 forks source link

continue committing after binary content exception #5

Closed SaschaHeyer closed 5 years ago

SaschaHeyer commented 5 years ago

The Google Cloud Search Norconex Committer (latest version v1-0-0.4) does not continue the committing process if one of the documents doesn't contain binary content.

This fix allows the committer to continue at with the documents with valid binary content.

donghanmiao commented 5 years ago

Could you please write a unit test for it?

neil-s commented 5 years ago

@SaschaHeyer we would really love to have you as a contributor on this project, as soon as you add unit tests. Really appreciate the extra work you're sharing back with the community.

joelvoss commented 5 years ago

Because my colleague hasn't had the time to write unit tests so far, I have created a PR (https://github.com/google-cloudsearch/norconex-committer-plugin/pull/9) to provide them. Feel free to review.

SaschaHeyer commented 5 years ago

solved with https://github.com/google-cloudsearch/norconex-committer-plugin/pull/9