search

google-cloudsearch / norconex-committer-plugin

Google Cloud Search Norconex HTTP Collector Indexer Plugin
Apache License 2.0
5 stars 7 forks source link

Fix/catch exception on batch #9

Closed joelvoss closed 5 years ago

joelvoss commented 5 years ago

This PR is based on https://github.com/google-cloudsearch/norconex-committer-plugin/pull/5 and https://github.com/google-cloudsearch/norconex-committer-plugin/pull/7 as both are needed for the committer plugin to function reliably.

I've added the missing unit tests and modified the existing ones to assert logged exceptions instead of expecting a throw.

donghanmiao commented 5 years ago

Thank you Joel. We have just checked in PR#7, please rebase your commit. Thanks.

joelvoss commented 5 years ago

@donghanmiao , i just rebased my commits. Feel free to review. Thanks!