search

google-code-backups / proveit-js

Automatically exported from code.google.com/p/proveit-js
0 stars 0 forks source link

Use Wikipedia's jQuery(UI) instance(s) for ProveIt #67

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Currently ProveIt uses its own instances of jQuery and jQueryUI. If possible, 
it would be good to use the instances that Wikipedia automatically loads.

Here is the version breakdown:

proveit:

jquery.js 1.4
http://ajax.googleapis.com/ajax/libs/jquery/1.4/jquery.min.js

jqueryui.js 1.8.3
http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.3/jquery-ui.min.js

jqueryui.css 1.8.3
http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.3/themes/base/jquery-ui.css

--

wikipedia:

jquery.js 1.4.2
http://bits.wikimedia.org/skins-1.5/common/jquery.min.js

jqueryui.js 1.7.1
http://bits.wikimedia.org/w/extensions/UsabilityInitiative/js/js2stopgap/jui.com
bined.min.js

jqueryui.css 1.7.2
http://bits.wikimedia.org/w/extensions/UsabilityInitiative/css/vector/jquery-ui-
1.7.2.css

Original issue reported on code.google.com by kurt.luther on 12 Oct 2010 at 8:07

GoogleCodeExporter commented 8 years ago 
Also would be nice to group together all the hard-coded URLs and make them 
constants/variables, similar to STATIC_BASE.

Original comment by kurt.luther on 12 Oct 2010 at 8:09

GoogleCodeExporter commented 8 years ago 
I will also move the body of the anonymous function at the bottom into load.

Original comment by matthew....@gatech.edu on 12 Oct 2010 at 8:13

GoogleCodeExporter commented 8 years ago 
As of 5e7b19b64d, the hard-coded URLs are grouped together as variables, and 
ProveIt now uses Wikipedia's version of jQuery.

We still have to use Google's version of jQueryUI because Wikipedia uses a 
stripped-down version that lacks many features we use. For example, Wikipedia's 
version doesn't have tabs.

Leaving this issue open until the anonymous function is moved into load.

Original comment by kurt.luther on 14 Oct 2010 at 3:53

GoogleCodeExporter commented 8 years ago 
Fixed in revision c7b44.  We use the already-loaded static Wikipedia version of 
jQuery.  In load, we conditionally (if we're on a supported page) load jQueryUI 
and call createGUI.

Original comment by matthew....@gatech.edu on 22 Oct 2010 at 8:30