search

google-code-backups / xinc

Automatically exported from code.google.com/p/xinc
0 stars 0 forks source link

Plugin_Repos_Api_Documentation.php->_getDocumentationFile() fails for URLs with a space in them #162

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
If you have an alias with a space in it then the perl regular expression
will fail.

/api/documentation/get/file/Shared%20Library/1209575232/phpUnit%20Documentation/
phpunit2-noframes.htm

The fix is to change line 118 of Plugin/Repos/Api/Documentation.php from:

        $query = $_SERVER['REQUEST_URI'];

to

        $query = urldecode($_SERVER['REQUEST_URI']);

Original issue reported on code.google.com by james.co...@gmail.com on 30 Apr 2008 at 5:33

GoogleCodeExporter commented 8 years ago 
My bad - it's not the regexp that fails. It's the code on L161:169 but the fix 
is
still valid.

Original comment by james.co...@gmail.com on 30 Apr 2008 at 5:35

GoogleCodeExporter commented 8 years ago 
thx. will work it in shortly

Original comment by arnos...@gmail.com on 30 Apr 2008 at 5:41

GoogleCodeExporter commented 8 years ago

Original comment by arnos...@gmail.com on 30 Apr 2008 at 9:52

GoogleCodeExporter commented 8 years ago 
The same code fix should also be applied to:

./Plugin/Repos/Api/Documentation.php:118
./Plugin/Repos/Api/Artifacts.php:123
./Plugin/Repos/Api/Deliverable.php:118
./Plugin/Repos/Gui/Dashboard/Widget.php:57
./Plugin/Repos/Gui/Artifacts/Widget.php:65

/me wishes he'd chosen a project name without a space in it!

Original comment by james.co...@gmail.com on 1 May 2008 at 10:58

GoogleCodeExporter commented 8 years ago 
And I thank for the bug report ;) Keep on bugging

Original comment by arnos...@gmail.com on 1 May 2008 at 11:09

GoogleCodeExporter commented 8 years ago

Original comment by arnos...@gmail.com on 1 May 2008 at 5:45

GoogleCodeExporter commented 8 years ago

Original comment by arnos...@gmail.com on 2 May 2008 at 11:01