onrecovery publisher is failing

[GoogleCodeExporter]

If I remove the "onsuccess" publisher, I only receive notification of
failures, no notification of recovery.

To reproduce:
1. Define onrecovery, onsuccess, and onfailure publishers
2. Make the build fail -- onfailure publisher gets processed (correctly)
3. Make the build pass -- onsuccess publisher gets processed (incorrectly)
4. Make the build pass again -- onsuccess publisher gets processed (correctly)

I would expect the onrecovery publisher to process on the first passing
build after a failure. Instead, this is seen as a 'success' rather than a
'recovery'.

----

This is my configuration:

<publishers>
  <onfailure>
    <email to="m...@email.com" subject="Build failed" message="$
{build.failure.message}" />
  </onfailure>
  <onrecovery>
    <email to="m...@email.com" subject="Build recovered" message="$
{build.recovery.message}" />
  </onrecovery>
  <onsuccess>
    <email to="m...@email.com" subject="Build succeeded" message="$
{build.success.message}" />
  </onsuccess>
</publishers>

This is what my log says on the first successful build after a failure
(when no onsuccess is defined):

[info]   [2009-06-03 11:40:05-America/Los_Angeles] [build] hackday:
Processing builders done
 [info]   [2009-06-03 11:40:05-America/Los_Angeles] [build] hackday:
BUILD PASSED
 [info]   [2009-06-03 11:40:05-America/Los_Angeles] Processing task:
publishers
 [info]   [2009-06-03 11:40:05-America/Los_Angeles] [build] hackday:
Processing publishers
 [info]   [2009-06-03 11:40:05-America/Los_Angeles] [build] hackday:
Last Build status: -2
 [info]   [2009-06-03 11:40:05-America/Los_Angeles] [build] hackday:
Processing publishers done
 [info]   [2009-06-03 11:40:05-America/Los_Angeles] Setting loglevel
to 2
 [info]   [2009-06-03 11:40:05-America/Los_Angeles] Next buildtime:
2009-06-03 11:40:12

If I define onsuccess (and onrecovery) this is what the log says on
the first success after a failure:

 [info]   [2009-06-03 11:51:20-America/Los_Angeles] [build] hackday:
Processing builders done
 [info]   [2009-06-03 11:51:20-America/Los_Angeles] [build] hackday:
BUILD PASSED
 [info]   [2009-06-03 11:51:20-America/Los_Angeles] Processing task:
publishers
 [info]   [2009-06-03 11:51:20-America/Los_Angeles] [build] hackday:
Processing publishers
 [info]   [2009-06-03 11:51:20-America/Los_Angeles] [build] hackday:
Last Build status: -2
 [info]   [2009-06-03 11:51:20-America/Los_Angeles] [build] hackday:
Publishing with OnSuccess Publishers
 [info]   [2009-06-03 11:51:20-America/Los_Angeles] [build] hackday:
Publishing with OnSuccess Publisher:
Xinc_Plugin_Repos_Publisher_Email_Task
 [info]   [2009-06-03 11:51:20-America/Los_Angeles] [project] hackday:
Executing email publisher with content  (...) 

Original issue reported on code.google.com by katrina....@gmail.com on 14 Aug 2009 at 3:44

[GoogleCodeExporter]

Forgot to mention: I'm using version 2.0.0-b196

Original comment by katrina....@gmail.com on 14 Aug 2009 at 3:50

[GoogleCodeExporter]

Ok, I've checked out 2.0.3, and have confirmed that this is still failing in 
that branch.

More info:

It seems like the status of the previous build is always set to -2, regardless 
of the
outcome. Not certain where the -2 is coming from (possibly 
modificationset/failed?)

Xinc_Build_Interface::FAILED equals 0
Xinc_Build_Interface::PASSED equals 1

Original comment by katrina....@gmail.com on 14 Aug 2009 at 6:34

[GoogleCodeExporter]

Original comment by opitz.al...@googlemail.com on 1 Oct 2011 at 11:30

• Added labels: Milestone-v3.0