Bugs in config.rb and barcode_generator.rb for code39

[GoogleCodeExporter]

The barcode in code39 generated by barcode-generator are not good.

2 errors : 
1) in lib/config.rb : 

replace :
DEFAULT_ENCODING = Gbarcode::BARCODE_39
by :
DEFAULT_ENCODING = Gbarcode::BARCODE_39 | Gbarcode::BARCODE_NO_CHECKSUM
because code39 no use checksum

2) in lib/barcode_generator.rb
dont add '*', because Gbarcode add it automaticaly.

Sorry for my bad english, i'm french.

AGASSE Baptiste.

baptiste.agasse (at) gmail.com

Original issue reported on code.google.com by agas...@gmail.com on 16 Jan 2008 at 10:43

Attachments:

• config.rb
• barcode_generator.rb

[GoogleCodeExporter]

Thanks Agasse.

I will change the default encoding option to not use checksum with code39.

Not sure about '*' . A user complained that the barcode won't scan if '*' was 
not
added around the barcode. I will look into this matter. In the meantime, you 
can set
ASKTERISKIZE to false and achieve same effect.

-anuj.

Original comment by anuj.luthra@gmail.com on 16 Jan 2008 at 2:29

• Changed state: Started

[GoogleCodeExporter]

>> In the meantime, you can set
ASKTERISKIZE to false and achieve same effect.
Yes, thanks.

For the '*', if i add them, the barcode won't scan.
I have compared barcode generated with rails and barcode-generator and one that 
i've
make with OOo and code39 font. they are identical when i don't add '*' with
barcode-generator and scan is OK.

regards

Baptiste.

Original comment by agas...@gmail.com on 16 Jan 2008 at 2:39

[GoogleCodeExporter]

committed the no checksum flag with code39

Original comment by anuj.luthra@gmail.com on 16 Jan 2008 at 2:40

[GoogleCodeExporter]

you convince me :)

taken the asterisk out and committed. 

Original comment by anuj.luthra@gmail.com on 16 Jan 2008 at 3:11

• Changed state: Fixed