google-code-export / beets

Automatically exported from code.google.com/p/beets
MIT License
0 stars 0 forks source link

Amazon cover.gif displays #363

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What's the problem? How can I reproduce it?

Use beets as per usual, when accessing Amazon's API beets grabs possibly any of 
their images even if the cover art's not actually available.  The result is 
http://i.imgur.com/8mrH3.gif on a few albums.

If it seems relevant, what system are you running on (OS, Python version,
etc.)?

GNU/Linux, Fedora 16 x32 (and tested x64).  Python 2.7.2

I would suggest possibly blocking *.gif from amazon.com. 

Original issue reported on code.google.com by wyatt.br...@gmail.com on 21 Mar 2012 at 8:52

GoogleCodeExporter commented 9 years ago
Only JPEG images should be allowed already: 
https://github.com/sampsyo/beets/blob/master/beets/autotag/art.py#L32
If GIFs are slipping through, then this is a bug. Do you have an example of an 
album that gets this "not found" image when beets tags it (for testing)?

Original comment by adrian.sampson on 21 Mar 2012 at 9:38

GoogleCodeExporter commented 9 years ago
The ones I found were:

[me.box ~]# locate cover.gif
/storage/music/flac/Bad_Religion_-_Into_the_Unknown/cover.gif
/storage/music/flac/Hexstatic_-_Hexstatic_presents-_Videos_Remixes_Rarities/cove
r.gif
/storage/music/flac/Less_Than_Jake_-_Borders_&_Boundaries/cover.gif
/storage/music/flac/Modest_Mouse_-_Interstate_8/cover.gif
/storage/music/flac/Screw_32_-_Unresolved_Childhood_Issues/cover.gif
/storage/music/flac/Wilco_-_Sky_Blue_Sky/cover.gif
[me.box ~]#

I'll try retagging a couple again with b13.

Original comment by wyatt.br...@gmail.com on 21 Mar 2012 at 10:20

GoogleCodeExporter commented 9 years ago
Reran on Modest Mouse - Interstate 8 with b13 and it seems to *not* have the 
same issue.  Weird.

Original comment by wyatt.br...@gmail.com on 21 Mar 2012 at 10:30

GoogleCodeExporter commented 9 years ago
Strange. Well, if the issue crops up again, let me know here and we'll reopen 
the ticket.

Original comment by adrian.sampson on 26 Mar 2012 at 10:25