google-code-export / bibapp

Automatically exported from code.google.com/p/bibapp
Other
0 stars 0 forks source link

Tests are out of date #188

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Install BibApp via the instructions and then 'rake test'.

This will result in some errors and no tests actually being run. It looks like 
some of this is from rails 2.2 -> 2.3 migration and some is just from not 
updating the tests as the application evolved.

Many of the test files don't have any real tests in them.

The tests that do exist are old style tests, which is not bad in and of itself, 
but for new tests it would be nice to move at least to rspec style tests and 
perhaps at some point something like cucumber.

I plan to attempt to fix the tests as they are now so that they'll run at least 
and then think about adding rspec as I prepare to work on other issues.

Original issue reported on code.google.com by hadi...@gmail.com on 12 Jan 2011 at 4:59

GoogleCodeExporter commented 9 years ago
Commits 1531-1535 make the tests run again, although most still fail.

Looking at them I'm not sure that they ever passed (for some it looks like the 
functionality may never have been implemented), but I'm going to go through them
and see what can be saved.

Original comment by hadi...@gmail.com on 12 Jan 2011 at 6:45

GoogleCodeExporter commented 9 years ago
In commits 1536-1539 I set things up to use rspec and related technologies 
(rspec_rails, factory_girl, shoulda, rcov). I also add my .gitignore file (I'm 
using git-svn, and it would be useful for anyone else who chooses to do so).

Original comment by hadi...@gmail.com on 12 Jan 2011 at 10:45

GoogleCodeExporter commented 9 years ago
Also, I may not try to fix the old style tests beyond what I've done. There 
aren't many of them anyway, and inasmuch as I do anything with them it'll 
probably be easier to just adapt them to rspec.

Original comment by hadi...@gmail.com on 12 Jan 2011 at 10:46

GoogleCodeExporter commented 9 years ago
On the Github site there are now more (although by no means enough) tests and 
these are updated to rspec tests. I've removed the old style tests. I will add 
cucumber tests soon.

Original comment by hadi...@gmail.com on 28 Jun 2011 at 4:07