Change PayPal Fee calculation in GL File

[GoogleCodeExporter]

PayPal has agreed to reduce their fees on the payment reference trasnaction 
from 1.1% + 30c to 1.1% + 10c.

Once PayPal has varied the rate in their system, the GL File download must also 
be changed to reflect the new rate.

Both the amounts against the GL codes 4690 and 6340 will need to be varied in 
line with the new rate.

Original issue reported on code.google.com by r...@farmhousedirect.com.au on 27 Jul 2012 at 5:48

[GoogleCodeExporter]

Original comment by r...@farmhousedirect.com.au on 30 Jul 2012 at 11:06

• Added labels: Release-7.1
• Removed labels: Release-8.0

[GoogleCodeExporter]

Need to double check the system as well.

Original comment by Hui....@gmail.com on 31 Jul 2012 at 12:10

[GoogleCodeExporter]

Roy -  I will do some investigations as we discussed from a display side, 
please proceed with the code investigations also. 

Original comment by dan...@farmhousedirect.com.au on 1 Aug 2012 at 4:12

• Changed state: 2-Assigned

[GoogleCodeExporter]

Original comment by Hui....@gmail.com on 1 Aug 2012 at 8:29

• Changed state: 3-Progressing

[GoogleCodeExporter]

export file updated

Original comment by Hui....@gmail.com on 1 Aug 2012 at 12:48

• Changed state: 4-ReadyForTest

[GoogleCodeExporter]

Hi Roy, 

I need to get a bit more of an idea of what changes have been made so that I 
can test it. Currently I have gone into the general ledger area in the admin 
section, it seems that it is still using the old formula. Thanks! 

Daniel 

Original comment by dan...@farmhousedirect.com.au on 7 Aug 2012 at 1:50

[GoogleCodeExporter]

Yeah, this is for the General Ledger download file.

The last two columns are changed. This is the change:

FROM
<text>4690,@string.Format("{0:yyyyMMdd}", 
o.Time),104475,@string.Format("{0:N}", o.Amount * 0.011m + 
0.3m),1,,farmhousedirect.com.au - @o.Id,,,ZA</text>
<text>6340,@string.Format("{0:yyyyMMdd}", 
o.Time),104475,@string.Format("-{0:N}", o.Amount * 0.011m + 
0.3m),1,,farmhousedirect.com.au - @o.Id,,,ZZ</text>

TO
<text>4690,@string.Format("{0:yyyyMMdd}", 
o.Time),104475,@string.Format("{0:N}", o.Amount * 0.011m + 
0.1m),1,,farmhousedirect.com.au - @o.Id,,,ZA</text>
<text>6340,@string.Format("{0:yyyyMMdd}", 
o.Time),104475,@string.Format("-{0:N}", o.Amount * 0.011m + 
0.1m),1,,farmhousedirect.com.au - @o.Id,,,ZZ</text>

Original comment by Hui....@gmail.com on 7 Aug 2012 at 2:01

[GoogleCodeExporter]

Thanks for that extra information I've just taken a little extract from the GL 
as an example of what I'm looking at: 

5420 | 20120507 | 104475 | 2.48 | 1 | farmhousedirect.com.au - 250 | ZZ
2782 | 20120507 | 104475 |-2.48 | 1 | farmhousedirect.com.au - 250 | S1
4690 | 20120507 | 104475 | 0.33 | 1 | farmhousedirect.com.au - 250 | ZA
6340 | 20120507 | 104475 | -0.33 | 1 | farmhousedirect.com.au - 250 | ZZ

Currently the fee portion is 0.33 which is the result of the calculation: 
(2.48  * 0.011) + 0.3 = $0.33 

If we had changed to the new fee structure the result should be: 
(2.48  * 0.011) + 0.1 = $0.13

Original comment by dan...@farmhousedirect.com.au on 7 Aug 2012 at 2:16

[GoogleCodeExporter]

Dev changed the test env to 7.0.2, changing it back in an hour.

Original comment by Hui....@gmail.com on 7 Aug 2012 at 2:21

[GoogleCodeExporter]

fixed

Original comment by Hui....@gmail.com on 7 Aug 2012 at 3:12

[GoogleCodeExporter]

Thanks Roy, just had something else to clarify with you regarding this. Will 
this change be made on all transactions in the system or will it only be 
effective from the moment we make the changes to prod? 

Original comment by dan...@farmhousedirect.com.au on 7 Aug 2012 at 4:38

[GoogleCodeExporter]

The way the system calculates it in the download file will be changed.

The change is not time sensitive.

It means this potentially will have an timing issue. If you are using the new 
fomular to generate historical data, it will have an incorrect value.  

Original comment by Hui....@gmail.com on 7 Aug 2012 at 4:42

[GoogleCodeExporter]

If the payment reference transaction record was created before 1st August 2012 
then use the 1.1% + 30c calculation and created >= 1st August 2012 then use the 
1.1% + 10c calculation.

Original comment by Hui....@gmail.com on 8 Aug 2012 at 12:32

• Changed state: 3-Progressing

[GoogleCodeExporter]

Original comment by Hui....@gmail.com on 9 Aug 2012 at 10:21

• Changed state: 4-ReadyForTest

[GoogleCodeExporter]

Verified that items after 1st August is using the new calculation. 

Older items remain at the old forumla. 

Original comment by dan...@farmhousedirect.com.au on 10 Aug 2012 at 1:43

• Changed state: 5-Accepted

[GoogleCodeExporter]

Original comment by daniel...@gmail.com on 14 Aug 2012 at 6:23

[GoogleCodeExporter]

Original comment by daniel...@gmail.com on 16 Aug 2012 at 4:17

[GoogleCodeExporter]

Rob will test this once issue 209 data clean-up has been completed

Original comment by Rob...@gmail.com on 21 Aug 2012 at 7:59

• Added labels: ActionDate-2012-08-22
• Removed labels: ActionDate-TBC

[GoogleCodeExporter]

Ran the GL file today in live and all good.

Original comment by Rob...@gmail.com on 24 Aug 2012 at 6:21

• Changed state: Completed