Click and Send Login API - phone number field error

google-code-export / bignoze

Automatically exported from code.google.com/p/bignoze

0 stars 0 forks source link

Click and Send Login API - phone number field error #449

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

We have a situation where the phone entered for the buyer contains "-" and this 
has caused an error in the C&S login API.

See attached for the C&S screen capture and sample XML.

What can we do on FHD to avoid this situation occurring?

I do not think we need to fix this in the regsitration API as we have the 
ability to get the producer to change the phone number data directly in the 
site... whereas we cannot udpate the order once it has been placed.

Original issue reported on code.google.com by Rob...@gmail.com on 25 Jan 2013 at 12:30

Attachments:

[Phone number.docx](https://storage.googleapis.com/google-code-attachments/bignoze/issue-449/comment-0/Phone number.docx)

GoogleCodeExporter commented 9 years ago

Tech alternatives

Option A - strip "-" on API Call
Option B - strip "-" on Input, as well as on API Call

Original comment by Hui....@gmail.com on 25 Jan 2013 at 12:33

GoogleCodeExporter commented 9 years ago

Option A, please

Original comment by Rob...@gmail.com on 25 Jan 2013 at 1:16

GoogleCodeExporter commented 9 years ago

To confirm: just for the fields where they do not allow "-" but NOT a blanket 
on all fields.  Does this affect just the phone number field or others as well?

Original comment by Rob...@gmail.com on 25 Jan 2013 at 1:18

GoogleCodeExporter commented 9 years ago

Let's just strip "-" on Phone fields

Original comment by Hui....@gmail.com on 25 Jan 2013 at 1:20

GoogleCodeExporter commented 9 years ago

OK

Original comment by Rob...@gmail.com on 25 Jan 2013 at 1:45

GoogleCodeExporter commented 9 years ago

Roy - sorry to be pain.  Can we just not pass the phone number all together?

Original comment by Rob...@gmail.com on 25 Jan 2013 at 1:59

GoogleCodeExporter commented 9 years ago

Are you requesting that we shouldn't pass phone number if it contains - or 
don't pass any phones in any situations?

Original comment by Hui....@gmail.com on 25 Jan 2013 at 2:21

GoogleCodeExporter commented 9 years ago

We have decided to stop sending through the phone number all together – as we 
don’t want it showing on the Click and Send label.

Original comment by Rob...@gmail.com on 25 Jan 2013 at 5:05

GoogleCodeExporter commented 9 years ago

Removing 
sb.AppendFormat("<Telephone>{0}</Telephone>", FormatAndShortStr(order.Phone, 
20));

The entire <Telephone> Structure from Login call

Removing
sb.AppendFormat("<self-user-phonenumber>{0}</self-user-phonenumber>", 
FormatAndShortStr(phoneNumber, 17));
The entire <self-user-phonenumber> from Sign up call

Original comment by Hui....@gmail.com on 25 Jan 2013 at 8:44

Changed state: 4-ReadyForTest

GoogleCodeExporter commented 9 years ago

The phone has been inadvertently removed from the sign-up as well as the login 
call.  Please only remove from the login call.

Original comment by Rob...@gmail.com on 29 Jan 2013 at 6:02

Changed state: 2-Assigned

GoogleCodeExporter commented 9 years ago

Original comment by Hui....@gmail.com on 29 Jan 2013 at 7:02

Changed state: 4-ReadyForTest

GoogleCodeExporter commented 9 years ago

Re-tested both Registration and Log in and both are now working as expected.

Original comment by Rob...@gmail.com on 29 Jan 2013 at 8:04

Changed state: 5-Accepted

GoogleCodeExporter commented 9 years ago

Original comment by Miki...@gmail.com on 6 Feb 2013 at 4:12

Changed state: Completed