Closed GoogleCodeExporter closed 9 years ago
Original comment by watusim...@bitfighter.org
on 29 Aug 2011 at 9:33
When completing issue 129, I noticed that all of these commands use the
serverCommandHandler in UIGame.cpp and that they did not exist in the giant
CommandInfo struct.
I added them to the struct which means that at least #3 is completed above for
these commands.
Original comment by buckyballreaction
on 10 Oct 2011 at 1:44
The server command handler is an easy way to add commands, but, in my opinion,
it sort of subverts the whole intent of forcing all commands to pass through
the struct that in turn forces documentation of the methods. Perhaps there's a
way to get the server command handler to process commands from the struct
rather than the way it's being done now? thoughts?
Original comment by watusim...@bitfighter.org
on 10 Oct 2011 at 8:22
Except I put these commands into the CommandInfo documenting struct... it's
just that the struct calls serverCommandHandler. Unless, you are thinking of
another place?
Original comment by buckyballreaction
on 19 Oct 2011 at 4:23
Finally finished with this with rda60a68bac5a.
serverCommandHandler was left for future compatibility reasons (it's a great
hack to not need to change RPC commands and thus bitfighter major versions)
Original comment by buckyballreaction
on 24 Oct 2011 at 2:35
Original issue reported on code.google.com by
ch...@eykamp.com
on 29 Aug 2011 at 9:32