google-code-export / bwapi

Automatically exported from code.google.com/p/bwapi
0 stars 0 forks source link

svnrev.h rev not always right #141

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. in r1656 shows 1651

What is the expected output? What do you see instead?
1656. 1651

What version of the product are you using? On what operating system?
r1656

Please provide any additional information below.
svnrev.h should be changed in this way:

#define SVN_REV $Revision: $
#define SVN_REV_STR "$Revision: $"

then do command line:
svn propset svn:keywords "Revision" svnrev.h

after that, the rev number will be automatically changed every time commit
to svn.

Original issue reported on code.google.com by neoedmund on 27 Nov 2009 at 3:36

GoogleCodeExporter commented 9 years ago
that's what revisionUpdate.bat is for

Original comment by goo...@teabix.com on 27 Nov 2009 at 7:30

GoogleCodeExporter commented 9 years ago
It used to be a pre-build event, but apparently doesn't work for lowerlogic.

Original comment by AHeinerm on 27 Nov 2009 at 10:32

GoogleCodeExporter commented 9 years ago

Original comment by AHeinerm on 27 Nov 2009 at 10:32

GoogleCodeExporter commented 9 years ago
I fixed that in r1648

Original comment by goo...@teabix.com on 27 Nov 2009 at 10:55

GoogleCodeExporter commented 9 years ago
@lowerlogic: but you better try before marking

Original comment by goo...@teabix.com on 27 Nov 2009 at 10:56

GoogleCodeExporter commented 9 years ago
why not use "svn propset", it's more clear.

Original comment by neoedmund on 28 Nov 2009 at 4:39

GoogleCodeExporter commented 9 years ago
Never heard of it. :D

Original comment by AHeinerm on 28 Nov 2009 at 5:44

GoogleCodeExporter commented 9 years ago
maybe "svn propset" is not good, because rev string only change only if THE 
file is
changed. in this case maybe a pre-build event is better.

Original comment by neoedmund on 28 Nov 2009 at 9:22

GoogleCodeExporter commented 9 years ago
turns out I just needed to update TortoiseSVN. revisionUpdate.bat works now.

Original comment by lowerlo...@gmail.com on 29 Nov 2009 at 7:27