Tank/dropship crash

[GoogleCodeExporter]

What steps will reproduce the problem?
1. if you try to use dropship -> load (tank) game crashes also on 
dropship -> rightclick(tank)

2. dropship -> load (unit) works on any unit except tanks, even works on 
hero tanks

3. tank -> rightclick (ds) does work however

What version of the product are you using? On what operating system?
2.4

Original issue reported on code.google.com by niekkrem...@hotmail.com on 1 Dec 2009 at 7:03

[GoogleCodeExporter]

Problem also occurs for unloading

You can however unload with

for each(Unit* u in DS->getLoadedUnits()){
    Broodwar->printf("%d", u->getType());
    DS->unload(u);}

But not with 

DS->unload(Tank)

Original comment by niekkrem...@hotmail.com on 1 Dec 2009 at 7:14

[GoogleCodeExporter]

does the same problem appear with goliaths?

Original comment by goo...@teabix.com on 1 Dec 2009 at 7:18

[GoogleCodeExporter]

maybe this is somehow related to issue 154, which also crashes with siege tanks.

Original comment by lowerlo...@gmail.com on 1 Dec 2009 at 7:58

[GoogleCodeExporter]

It's most likely a similar issue, when building the commands the string is 
longer
than the buffer because of "Terran Siege Tank Tank Mode"

Original comment by emartel@gmail.com on 2 Dec 2009 at 12:47

[GoogleCodeExporter]

Goliath, hero siege tanks are fine. just normal siege tanks
also the Terran Siege Tank Tank Mode isnt loaded but the unit pointer. which 
should 
be shorter i think

Original comment by niekkrem...@hotmail.com on 2 Dec 2009 at 1:09

[GoogleCodeExporter]

Original comment by lowerlo...@gmail.com on 7 Dec 2009 at 1:04

• Added labels: Type-Defect, Priority-Medium

[GoogleCodeExporter]

Just made a UMS map to test and it looks like emartel's fix for Issue 154 also 
fixed
this issue. Tested and all 4 of the following work:

ds->load(tank)
ds->unload(tank)
ds->rightClick(tank)
tank->rightClick(ds)

Original comment by lowerlo...@gmail.com on 20 Dec 2009 at 7:48

• Changed state: Fixed

[GoogleCodeExporter]

Does this mean that it will be fixed in the next version of BWAPI ?

Original comment by niekkrem...@hotmail.com on 20 Dec 2009 at 11:41