google-code-export / bwapi

Automatically exported from code.google.com/p/bwapi
0 stars 0 forks source link

Solution relies on global directories for includes #162

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
Open a fully synced svn copy's .sln
Update solution as needed (I had to upgrade to 2010 format).
Try to build

What is the expected output? What do you see instead?
Expected: dll to build, no compile errors
Actual: Cannot open <file> for tons of different files, various problems
related to use of numbers for an expected enum, etc
e.g. svnrev.h and util/bitmask.h are missing
The svnrev should be created by SubWCRev, but that program fails to start

What version of the product are you using? On what operating system?
svn HEAD on VS2010 (MS internal build) on Windows 7 x64

Please provide any additional information below.
This problem can be alleviated by using a second computer to test changes
before check in. Currently, I believe whoever is making the solution files
has their visual studio settings configured with global directories.
Instead, include paths, libraries, et cetera should all be project-based
and set relatively instead of absolutely. 

Original issue reported on code.google.com by taw...@gmail.com on 7 Dec 2009 at 2:33

GoogleCodeExporter commented 9 years ago
Yeah Teabix is in the middle of a major change (see issue 134). I don't know 
why you
expect it to compile when the last code commit has a comment that starts with 
"not
working copy...". I get the exact same errors and I'm one of the main 
developers for
BWAPI. He should be able to commit something that at least compiles again 
tomorrow,
though it might be a week until we get everything completely working again in 
the new
system.

Original comment by lowerlo...@gmail.com on 7 Dec 2009 at 5:50

GoogleCodeExporter commented 9 years ago
r1761 compiles and runs, however its only part of the way through the 
transition so
very few interface functions work in that revision. The last completely working
revision of BWAPI is currently r1708 (BWAPI Beta 2.4 is r1689).

Original comment by lowerlo...@gmail.com on 7 Dec 2009 at 5:55

GoogleCodeExporter commented 9 years ago
the solution relies only on relative paths. My last change has triggered a 
chain 
reaction of changes, so there will be no working copy untill I match up every 
last 
class declaration. I cannot exactly tell when, because I just get some hundreds 
of 
errors, and how many there really are is ofcourse never known.

but we should find a TortoiseSVN independent replacement for SubWCRev.exe.

Original comment by goo...@teabix.com on 7 Dec 2009 at 11:03

GoogleCodeExporter commented 9 years ago
I placed a generateStub.bat in root so people without TortoiseSVN can generate 
their 
file, and place the correct revision number themselves, like we did earlier.

Original comment by goo...@teabix.com on 7 Dec 2009 at 5:05

GoogleCodeExporter commented 9 years ago
r1777 compiles :D

Original comment by lowerlo...@gmail.com on 7 Dec 2009 at 8:35

GoogleCodeExporter commented 9 years ago
seems like both subissues fixed. I hope there will be no more major changes, so 
for 
the time being this has been resolved.

Original comment by goo...@teabix.com on 7 Dec 2009 at 8:42

GoogleCodeExporter commented 9 years ago
Cannot open include file: BWAgent\all.h, no such file or directory.

Original comment by taw...@gmail.com on 7 Dec 2009 at 10:17

GoogleCodeExporter commented 9 years ago
run the run.bat in Interface Packer. it is required to generate the output 
interface, which our test AI, ConsoleAI, uses.

Original comment by goo...@teabix.com on 7 Dec 2009 at 10:41

GoogleCodeExporter commented 9 years ago
Perhaps this should be a separate bug then, but...
1) Run.bat uses a hardcoded path which does not exist when compiling a release 
build.
2) The interface packer project should be a requirement of the other projects 
which
require its outputs.
3) The interface packer project should have a postbuild step to execute the 
output
executable.

Original comment by taw...@gmail.com on 7 Dec 2009 at 10:48

GoogleCodeExporter commented 9 years ago
run.bat is thought to be only called when you are planning to create a featured 
download. Interface packer is not thought to change much at all. I was planning 
to 
run run.bat as postevent of BWAgent, but it got very annoying, since I'm 
constantly 
working on it, and it keeps flashing up although I do not need it. I will add 
it as 
postevent of BWAgent after major functionality is implemented, because from 
then on 
generating the interface will be required.

Original comment by goo...@teabix.com on 7 Dec 2009 at 10:57

GoogleCodeExporter commented 9 years ago
by the way Interface packer is only a tool and release build is not required

Original comment by goo...@teabix.com on 7 Dec 2009 at 11:00

GoogleCodeExporter commented 9 years ago
Release build is not required, but I'm using it for now, since the only reason 
I'm
currently trying to compile all this is for use with the AI competition. Since 
I'm
dogfooding our latest IDE/compiler, I cannot use the libraries you provide. 

An additional issue: BWAPI is missing link reference to ..\Release\Util.lib
Also, to remove warnings regarding target output name not matching for
BWAPI_ChaosLauncherInjector, change General>Target Extension to .bwl and
Linker>General>Output File to $(ChaosDir)\$(ProjectName)$(TargetExt)

Original comment by taw...@gmail.com on 7 Dec 2009 at 11:12