Scourge attack doesn't trigger onUnitDestroy

[GoogleCodeExporter]

What steps will reproduce the problem?

Print whenever onUnitDestroy is called, then attack a scourge into an air unit.

What is the expected output? What do you see instead?

I expect onUnitDestroy to be called since the scourge is removed from the
game. Instead, it is not called.

What version of the product are you using? On what operating system?

Beta 2.4 on Windows XP

Please provide any additional information below.

onUnitDestroy is called when a scourge is killed by other means.

Original issue reported on code.google.com by sharpe.m...@gmail.com on 21 Dec 2009 at 2:26

[GoogleCodeExporter]

due to a different approach to unit event detection, this issue is fixed in the 
BWAPI 3.0 branch

It's up to you guys if you want to fix it in the 2.x branch

Original comment by goo...@teabix.com on 21 Dec 2009 at 3:06

• Changed state: Questionable
• Added labels: Type-Defect

[GoogleCodeExporter]

onUnitDestroy is incorrectly labelled, and should be called onUnitDeath. It's 
just a
seriously bad hook.

Original comment by AHeinerm on 25 Dec 2009 at 3:58

[GoogleCodeExporter]

This will be the new hook:

0x0048AAC0 ; int __fastcall sub_48AAC0(int a1)

Original comment by AHeinerm on 31 Dec 2009 at 4:31

• Changed state: Started

[GoogleCodeExporter]

This issue was closed by revision r1890.

Original comment by lowerlo...@gmail.com on 1 Jan 2010 at 1:15

• Changed state: Fixed

[GoogleCodeExporter]

Implemented new hook in r1890. Tested and it works for scourge (both those that 
get
shot down and those that suicide into another flying unit).

Original comment by lowerlo...@gmail.com on 1 Jan 2010 at 1:18

[GoogleCodeExporter]

This problem seems to still exist for enemy scourge on Windows 7.

Versions:
- Windows 7.
- BWAPI Beta 2.6.1.
- W-Mode 1.02.

Reproduce:
- Print unit type name whenever onUnitDestroy is called.
- Get the single player competition maps here:
  http://eis.ucsc.edu/StarCraftTournament1
- Run the muta.scm map (UMS).
- Wait for enemy scourges to attack.

Results:
- Some calls are missing (Suiciding enemy scourges do not seem to trigger 
onUnitDestroy()).

Original comment by frel...@gmail.com on 20 Feb 2010 at 11:33

[GoogleCodeExporter]

Issue re-opened.

Original comment by AHeinerm on 21 Feb 2010 at 8:47

• Changed state: New

[GoogleCodeExporter]

Please verify if the same behaviour occurs in the latest revision.

Original comment by AHeinerm on 21 Feb 2010 at 8:47

[GoogleCodeExporter]

Original comment by AHeinerm on 7 Mar 2010 at 5:05

• Changed state: Started

[GoogleCodeExporter]

Still need to add this, it'll be done soon.

Original comment by AHeinerm on 7 Mar 2010 at 10:32

[GoogleCodeExporter]

Looks like this does in fact work, try r2126

Original comment by AHeinerm on 7 Mar 2010 at 11:41

• Changed state: Fixed

[GoogleCodeExporter]

Issue re-opened in r2127

Original comment by AHeinerm on 8 Mar 2010 at 8:40

• Changed state: Started

[GoogleCodeExporter]

fixed in r2215

Original comment by lowerlo...@gmail.com on 19 May 2010 at 7:02

• Changed state: Fixed