search

google-code-export / bwhf

Automatically exported from code.google.com/p/bwhf
0 stars 0 forks source link

Player's Network Problem? #40

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Two people using bw hf agent with player's network enabled

What is the expected output? What do you see instead?
Instead of it showing we played once together it shows twice since the same
exact game was sent.

What version of the product are you using? On what operating system?
Latest Version. Windows Vista

Original issue reported on code.google.com by MichaelJ...@gmail.com on 14 Aug 2009 at 8:12

GoogleCodeExporter commented 9 years ago 
The thing is that the Player's Network only distingushes games that have 
different 
replay. If you try to upload the same replay twice, it will only appear in the 
list 
once.

If you try to upload the replay of the "same" game from 2 different players, it 
will 
appear twice.

Which might be really 2 different games. For example if you take a 2v2 game for 
example in which a disconnect occurs during game, they might split to 2 1v1 
games and 
they can be played and eventually they will mean 2 different replays.

But yes, in many cases they are basically the same game just with a few seconds 
differs in the end of the game.

But again, games are only differentiated if the replay files differ.

Original comment by icz...@gmail.com on 17 Aug 2009 at 8:14

GoogleCodeExporter commented 9 years ago 
To eliminate this from happening can't you just check to see if all the players 
were 
the same, and if that was true and the game was uploaded within 3 minutes of 
one 
another mark it as the same game.

Original comment by MichaelJ...@gmail.com on 18 Aug 2009 at 6:27

GoogleCodeExporter commented 9 years ago 
Having the same players does not mean anything. Bunch of ppl usually play 
series of 
innies...
And for the 2nd part, replays can be added later at any time. Then the time of 
uploading can differ by any days or months.

Original comment by icz...@gmail.com on 18 Aug 2009 at 8:28

GoogleCodeExporter commented 9 years ago 
I understand that people play in-house games, lots of times sequentially, that 
is why
I suggested the 3 minute time limit plus matched player's names between uploads 
so no
games would accidentally be marked as a duplicate. Although this method would 
not
catch all duplicates I feel that it would catch a good majority. Also it 
appears that
the player's names are sent in the same order regardless of who uploaded them, 
this
to me would be a great asset in determining if a game is a duplicate.

Compare order of names, duration of game, time uploaded and I'm sure you could 
weed
out the duplicates almost 100%. Otherwise the way I look at it the charts of 
APM and
race selection could be significantly skewed with bad data.

Thanks for your response,
Mike

Original comment by MichaelJ...@gmail.com on 18 Aug 2009 at 8:47

GoogleCodeExporter commented 9 years ago 
The replay data contains game start time too...

Original comment by lurayl on 5 Dec 2009 at 7:41

GoogleCodeExporter commented 9 years ago 
Where? As far as I know, it only contains replay save time.

Original comment by icz...@gmail.com on 5 Dec 2009 at 7:43

GoogleCodeExporter commented 9 years ago 
It includes the random seed, (which is probably game start time), so that 
randomized
values remain the same.

Original comment by AHeinerm on 3 Feb 2010 at 6:31

GoogleCodeExporter commented 9 years ago 
I haven't looked into it, but the random seed does not have to be the game 
start time. 
It can be any random number calculated from maybe the current time, the free 
memory, 
free disk space... anything.

Original comment by icz...@gmail.com on 3 Feb 2010 at 8:15